Skip to content

Update getStorybook to return story parameters #5549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Update getStorybook to return story parameters #5549

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
68c63b9
Update getStorybook to return story parameters
timhaines Feb 11, 2019
5369be0
Update with Keraito's suggestions.
timhaines Feb 11, 2019
04e2b96
Undo changes to getStories, add getStoriesWithParameters
timhaines Feb 12, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/client-api/src/client_api.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -226,9 +226,9 @@ export default class ClientApi {
this._storyStore.getStoryKinds().map(kind => {
const fileName = this._storyStore.getStoryFileName(kind);

const stories = this._storyStore.getStories(kind).map(name => {
const render = this._storyStore.getStoryWithContext(kind, name);
return { name, render };
const stories = this._storyStore.getStories(kind).map(story => {
const render = this._storyStore.getStoryWithContext(kind, story.name);
return { name: story.name, render, parameters: story.parameters };
});

return { kind, fileName, stories };
Expand Down
9 changes: 7 additions & 2 deletions lib/client-api/src/client_api.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,10 +223,12 @@ describe('preview.client_api', () => {
{
name: 'name 1',
render: expect.any(Function),
parameters: expect.any(Object),
},
{
name: 'name 2',
render: expect.any(Function),
parameters: expect.any(Object),
},
],
}),
Expand All @@ -237,10 +239,12 @@ describe('preview.client_api', () => {
{
name: 'name 1',
render: expect.any(Function),
parameters: expect.any(Object),
},
{
name: 'name 2',
render: expect.any(Function),
parameters: expect.any(Object),
},
],
}),
Expand All @@ -265,6 +269,7 @@ describe('preview.client_api', () => {
{
name: 'name',
render: expect.any(Function),
parameters: expect.any(Object),
},
],
},
Expand Down Expand Up @@ -317,7 +322,7 @@ describe('preview.client_api', () => {
expect(firstStorybook).toEqual([
{
kind: 'kind',
stories: [{ name: 'story', render: expect.anything() }],
stories: [{ name: 'story', render: expect.anything(), parameters: expect.any(Object) }],
},
]);

Expand All @@ -333,7 +338,7 @@ describe('preview.client_api', () => {
expect(secondStorybook).toEqual([
{
kind: 'kind',
stories: [{ name: 'story', render: expect.anything() }],
stories: [{ name: 'story', render: expect.anything(), parameters: expect.any(Object) }],
},
]);
secondStorybook[0].stories[0].render();
Expand Down
4 changes: 2 additions & 2 deletions lib/client-api/src/story_store.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ export default class StoryStore extends EventEmitter {
return Object.keys(this._legacydata[key].stories)
.map(name => this._legacydata[key].stories[name])
.sort((info1, info2) => info1.index - info2.index)
.map(info => info.name);
.map(info => ({ name: info.name, parameters: info.parameters }));
}

getStoryFileName(kind) {
Expand Down Expand Up @@ -287,7 +287,7 @@ export default class StoryStore extends EventEmitter {
dumpStoryBook() {
const data = this.getStoryKinds().map(kind => ({
kind,
stories: this.getStories(kind),
stories: this.getStories(kind).map(story => story.name),
}));

return data;
Expand Down