-
-
Notifications
You must be signed in to change notification settings - Fork 9.8k
Core: Fix managerHead preset in main.ts
#22701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…it can be overloaded by user in main.ts
shilman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a "how to test" section to the description if we want to support the 6.5 API. The default implementation should read the value of manager-head.html if it exists and return its contents.
managerHead configuration possibility in main.tsmanagerHead preset in main.ts
That's what it does, of course.. |
|
@ndelangen it just returns the filename. It does not return the contents of the file. Pleas read my "how to test" addition to the PR description |
|
Understood, I'll fix it. |
Core: Fix `managerHead` preset in `main.ts`

Closes #22597
What I did
I moved the code to load manager-head.html to a preset value, then get the value needed by the builder-manager via presrt.apply.
This allows the user to set this value via main.ts if they so desire.
I also added this as a valid presetProperty in
StorybookConfiginterface.How to test
In a sandbox: