Skip to content

Conversation

@Hypnosphi
Copy link
Member

Issue: After #2807, backgrounds keep being present when switching to a non-background story

How to test

Open a story with backgrounds, then navigate to a story without them. Backgrounds should disappear

@Hypnosphi Hypnosphi added bug addon: backgrounds patch:yes Bugfix & documentation PR that need to be picked to main branch labels Mar 4, 2018
@codecov
Copy link

codecov bot commented Mar 4, 2018

Codecov Report

Merging #3142 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3142      +/-   ##
==========================================
+ Coverage   36.15%   36.16%   +<.01%     
==========================================
  Files         437      437              
  Lines        9429     9430       +1     
  Branches      883      899      +16     
==========================================
+ Hits         3409     3410       +1     
+ Misses       5470     5453      -17     
- Partials      550      567      +17
Impacted Files Coverage Δ
addons/background/src/BackgroundPanel.js 92.5% <100%> (+0.19%) ⬆️
app/vue/src/server/utils.js 0% <0%> (-100%) ⬇️
app/react/src/client/preview/element_check.js 67.64% <0%> (ø) ⬆️
...i/src/modules/ui/components/stories_panel/index.js 21.66% <0%> (ø) ⬆️
lib/ui/src/modules/ui/libs/filters.js 48.64% <0%> (ø) ⬆️
lib/ui/src/modules/ui/components/layout/usplit.js 38.7% <0%> (ø) ⬆️
lib/codemod/src/transforms/update-addon-info.js 50% <0%> (ø) ⬆️
addons/knobs/src/components/types/Button.js 11.9% <0%> (ø) ⬆️
...tions/src/lib/types/function/createFunctionEval.js 77.77% <0%> (ø) ⬆️
...tive/src/preview/components/StoryListView/index.js 0% <0%> (ø) ⬆️
... and 60 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83aac95...b7ea38e. Read the comment docs.

@Hypnosphi Hypnosphi merged commit b11ce55 into master Mar 4, 2018
@Hypnosphi Hypnosphi deleted the unset-background branch March 4, 2018 16:10
@Hypnosphi Hypnosphi added patch:done Patch/release PRs already cherry-picked to main/release branch and removed patch:done Patch/release PRs already cherry-picked to main/release branch labels Mar 6, 2018
Hypnosphi added a commit that referenced this pull request Mar 6, 2018
Unset background when switching to a non-background story
@Hypnosphi Hypnosphi added the patch:done Patch/release PRs already cherry-picked to main/release branch label Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addon: backgrounds bug patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants