Remove SB deps from cli tests #4705
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
igor-dv
requested review from
Hypnosphi,
ndelangen,
shilman,
stijnkoopal and
thomasbertet
as code owners
Hypnosphi
approved these changes
Nov 4, 2018
Codecov Report
@@ Coverage Diff @@
## next #4705 +/- ##
=======================================
Coverage ? 35.51%
=======================================
Files ? 557
Lines ? 6741
Branches ? 889
=======================================
Hits ? 2394
Misses ? 3884
Partials ? 463Continue to review full report at Codecov.
|
igor-dv
added
the
patch:yes
shilman
added
patch:done
This was referenced Dec 1, 2018
This was referenced Dec 1, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #4590 findings
What I did