Skip to content

Commit c0dd0ba

Browse files
Chris YangPark Sung Min
authored andcommitted
[connectivity]remove AndroidX constraint (flutter#2212)
After 0.4.5, we introduced a constraint that the app uses the plugin has to be migrated to androidx. This patch removes the constraint.
1 parent 0d0b5a2 commit c0dd0ba

File tree

7 files changed

+11
-17
lines changed

7 files changed

+11
-17
lines changed

packages/connectivity/CHANGELOG.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,7 @@
1+
## 0.4.5+1
2+
3+
* Android: Use android.arch.lifecycle instead of androidx.lifecycle:lifecycle in `build.gradle` to support apps that has not been migrated to AndroidX.
4+
15
## 0.4.5
26

37
* Support the v2 Android embedder.

packages/connectivity/android/build.gradle

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,9 +63,10 @@ afterEvaluate {
6363
if (!containsEmbeddingDependencies) {
6464
android {
6565
dependencies {
66-
def lifecycle_version = "2.1.0"
67-
api "androidx.lifecycle:lifecycle-common-java8:$lifecycle_version"
68-
api "androidx.lifecycle:lifecycle-runtime:$lifecycle_version"
66+
def lifecycle_version = "1.1.1"
67+
api "android.arch.lifecycle:runtime:$lifecycle_version"
68+
api "android.arch.lifecycle:common:$lifecycle_version"
69+
api "android.arch.lifecycle:common-java8:$lifecycle_version"
6970
}
7071
}
7172
}

packages/connectivity/android/src/main/java/io/flutter/plugins/connectivity/Connectivity.java

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,8 +11,6 @@
1111
import android.net.wifi.WifiInfo;
1212
import android.net.wifi.WifiManager;
1313
import android.os.Build;
14-
import androidx.annotation.NonNull;
15-
import androidx.annotation.Nullable;
1614

1715
/** Reports connectivity related information such as connectivity type and wifi information. */
1816
class Connectivity {
@@ -24,7 +22,6 @@ class Connectivity {
2422
this.wifiManager = wifiManager;
2523
}
2624

27-
@NonNull
2825
String getNetworkType() {
2926
if (android.os.Build.VERSION.SDK_INT >= Build.VERSION_CODES.M) {
3027
Network network = connectivityManager.getActiveNetwork();
@@ -44,7 +41,6 @@ String getNetworkType() {
4441
return getNetworkTypeLegacy();
4542
}
4643

47-
@Nullable
4844
String getWifiName() {
4945
WifiInfo wifiInfo = getWifiInfo();
5046
String ssid = null;
@@ -53,7 +49,6 @@ String getWifiName() {
5349
return ssid;
5450
}
5551

56-
@Nullable
5752
String getWifiBSSID() {
5853
WifiInfo wifiInfo = getWifiInfo();
5954
String bssid = null;
@@ -63,7 +58,6 @@ String getWifiBSSID() {
6358
return bssid;
6459
}
6560

66-
@Nullable
6761
String getWifiIPAddress() {
6862
WifiInfo wifiInfo = null;
6963
if (wifiManager != null) wifiInfo = wifiManager.getConnectionInfo();
@@ -81,7 +75,6 @@ String getWifiIPAddress() {
8175
return ip;
8276
}
8377

84-
@Nullable
8578
private WifiInfo getWifiInfo() {
8679
return wifiManager == null ? null : wifiManager.getConnectionInfo();
8780
}

packages/connectivity/android/src/main/java/io/flutter/plugins/connectivity/ConnectivityBroadcastReceiver.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
import android.content.Intent;
1010
import android.content.IntentFilter;
1111
import android.net.ConnectivityManager;
12-
import androidx.annotation.NonNull;
1312
import io.flutter.plugin.common.EventChannel;
1413

1514
/**
@@ -26,7 +25,7 @@ class ConnectivityBroadcastReceiver extends BroadcastReceiver
2625
private Connectivity connectivity;
2726
private EventChannel.EventSink events;
2827

29-
ConnectivityBroadcastReceiver(@NonNull Context context, @NonNull Connectivity connectivity) {
28+
ConnectivityBroadcastReceiver(Context context, Connectivity connectivity) {
3029
this.context = context;
3130
this.connectivity = connectivity;
3231
}

packages/connectivity/android/src/main/java/io/flutter/plugins/connectivity/ConnectivityMethodChannelHandler.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,6 @@
44

55
package io.flutter.plugins.connectivity;
66

7-
import androidx.annotation.NonNull;
87
import io.flutter.plugin.common.MethodCall;
98
import io.flutter.plugin.common.MethodChannel;
109

@@ -21,7 +20,7 @@ class ConnectivityMethodChannelHandler implements MethodChannel.MethodCallHandle
2120
* Construct the ConnectivityMethodChannelHandler with a {@code connectivity}. The {@code
2221
* connectivity} must not be null.
2322
*/
24-
ConnectivityMethodChannelHandler(@NonNull Connectivity connectivity) {
23+
ConnectivityMethodChannelHandler(Connectivity connectivity) {
2524
assert (connectivity != null);
2625
this.connectivity = connectivity;
2726
}

packages/connectivity/example/android/app/gradle.properties

Lines changed: 0 additions & 2 deletions
This file was deleted.

packages/connectivity/pubspec.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ description: Flutter plugin for discovering the state of the network (WiFi &
33
mobile/cellular) connectivity on Android and iOS.
44
author: Flutter Team <flutter-dev@googlegroups.com>
55
homepage: https://github.com/flutter/plugins/tree/master/packages/connectivity
6-
version: 0.4.5
6+
version: 0.4.5+1
77

88
flutter:
99
plugin:

0 commit comments

Comments
 (0)