Skip to content

Refactor init 2 #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 10, 2020
Merged

Refactor init 2 #28

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3a9f98a
refactor init
tomerd Mar 9, 2020
cfaf3fe
fixup
tomerd Mar 10, 2020
06c63ab
refactor init
tomerd Mar 9, 2020
e745040
another approach
tomerd Mar 9, 2020
a48be54
fixup
tomerd Mar 10, 2020
2f912de
fixup
tomerd Mar 10, 2020
93cbff0
fixup
tomerd Mar 10, 2020
4d5079a
typo
tomerd Mar 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
typo
  • Loading branch information
@tomerd
tomerd committed Mar 10, 2020
commit 4d5079a05c7138d2ea4ca54753c79d98f63d77e3
2 changes: 1 addition & 1 deletion Sources/SwiftAwsLambda/LambdaRunner.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ internal struct LambdaRunner {
/// - Returns: An `EventLoopFuture<LambdaHandler>` fulfilled with the outcome of the initialization.
func initialize(logger: Logger, factory: @escaping LambdaHandlerFactory) -> EventLoopFuture<LambdaHandler> {
logger.debug("initializing lambda")
// 1. craete the handler from the factory
// 1. create the handler from the factory
let future = bootstrap(eventLoop: self.eventLoop, lifecycleId: self.lifecycleId, offload: self.offload, factory: factory)
// 2. report initialization error if one occured
return future.peekError { error in
Expand Down