allow connect option to be passed as string

Author: Sergey Ninua

pymongo/common.py

@@ -439,7 +439,7 @@ def validate_ok_for_update(update):
     'document_class': validate_document_class,
     'tz_aware': validate_boolean_or_string,
     'uuidrepresentation': validate_uuid_representation,
-    'connect': validate_boolean,
+    'connect': validate_boolean_or_string,
     'event_listeners': _validate_event_listeners
 }
 

test/test_uri_parser.py

@@ -97,6 +97,7 @@ def test_split_options(self):
         self.assertRaises(ConfigurationError, split_options, 'foo')
         self.assertRaises(ConfigurationError, split_options, 'foo=bar;foo')
         self.assertTrue(split_options('ssl=true'))
+        self.assertTrue(split_options('connect=true'))
         self.assertTrue(split_options('ssl_match_hostname=true'))
 
         # Test Invalid URI options that should throw warnings.
@@ -118,6 +119,8 @@ def test_split_options(self):
                               'connectTimeoutMS=-1e100000', warn=True)
             self.assertRaises(Warning, split_options,
                               'ssl=foo', warn=True)
+            self.assertRaises(Warning, split_options,
+                              'connect=foo', warn=True)
             self.assertRaises(Warning, split_options,
                               'ssl_match_hostname=foo', warn=True)
 
@@ -153,6 +156,7 @@ def test_split_options(self):
         self.assertRaises(ValueError, split_options,
                           'connectTimeoutMS=-1e100000')
         self.assertRaises(ValueError, split_options, 'ssl=foo')
+        self.assertRaises(ValueError, split_options, 'connect=foo')
         self.assertRaises(ValueError, split_options, 'ssl_match_hostname=foo')
         if not (sys.platform == "win32" and sys.version_info <= (2, 5)):
             self.assertRaises(ValueError, split_options,