Skip to content

Commit fb207af

Browse files
committed
PYTHON-712 ObjectId.is_valid(None) should be False.
1 parent 2dc8409 commit fb207af

File tree

2 files changed

+4
-0
lines changed

2 files changed

+4
-0
lines changed

bson/objectid.py

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -140,6 +140,9 @@ def is_valid(cls, oid):
140140
141141
.. versionadded:: 2.3
142142
"""
143+
if not oid:
144+
return False
145+
143146
try:
144147
ObjectId(oid)
145148
return True

test/test_objectid.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -181,6 +181,7 @@ def test_pickle_backwards_compatability(self):
181181
self.assertEqual(oid_1_9, oid_1_10)
182182

183183
def test_is_valid(self):
184+
self.assertFalse(ObjectId.is_valid(None))
184185
self.assertFalse(ObjectId.is_valid(4))
185186
self.assertFalse(ObjectId.is_valid(175.0))
186187
self.assertFalse(ObjectId.is_valid({"test": 4}))

0 commit comments

Comments
 (0)