Skip to content

Commit cddcf9b

Browse files
Arman-Hosseininicolas-grekas
authored andcommitted
Improve some URLs
1 parent d129c01 commit cddcf9b

File tree

4 files changed

+12
-12
lines changed

4 files changed

+12
-12
lines changed

Pipes/WindowsPipes.php

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,8 +17,8 @@
1717
/**
1818
* WindowsPipes implementation uses temporary files as handles.
1919
*
20-
* @see https://bugs.php.net/bug.php?id=51800
21-
* @see https://bugs.php.net/bug.php?id=65650
20+
* @see https://bugs.php.net/51800
21+
* @see https://bugs.php.net/65650
2222
*
2323
* @author Romain Neutron <[email protected]>
2424
*
@@ -43,7 +43,7 @@ public function __construct($input, $haveReadSupport)
4343
// Fix for PHP bug #51800: reading from STDOUT pipe hangs forever on Windows if the output is too big.
4444
// Workaround for this problem is to use temporary files instead of pipes on Windows platform.
4545
//
46-
// @see https://bugs.php.net/bug.php?id=51800
46+
// @see https://bugs.php.net/51800
4747
$pipes = [
4848
Process::STDOUT => Process::OUT,
4949
Process::STDERR => Process::ERR,
@@ -105,8 +105,8 @@ public function getDescriptors()
105105
];
106106
}
107107

108-
// We're not using pipe on Windows platform as it hangs (https://bugs.php.net/bug.php?id=51800)
109-
// We're not using file handles as it can produce corrupted output https://bugs.php.net/bug.php?id=65650
108+
// We're not using pipe on Windows platform as it hangs (https://bugs.php.net/51800)
109+
// We're not using file handles as it can produce corrupted output https://bugs.php.net/65650
110110
// So we redirect output within the commandline and pass the nul device to the process
111111
return [
112112
['pipe', 'r'],

Process.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -152,8 +152,8 @@ public function __construct($commandline, $cwd = null, array $env = null, $input
152152

153153
// on Windows, if the cwd changed via chdir(), proc_open defaults to the dir where PHP was started
154154
// on Gnu/Linux, PHP builds with --enable-maintainer-zts are also affected
155-
// @see : https://bugs.php.net/bug.php?id=51800
156-
// @see : https://bugs.php.net/bug.php?id=50524
155+
// @see : https://bugs.php.net/51800
156+
// @see : https://bugs.php.net/50524
157157
if (null === $this->cwd && (\defined('ZEND_THREAD_SAFE') || '\\' === \DIRECTORY_SEPARATOR)) {
158158
$this->cwd = getcwd();
159159
}
@@ -451,7 +451,7 @@ public function getPid()
451451
/**
452452
* Sends a POSIX signal to the process.
453453
*
454-
* @param int $signal A valid POSIX signal (see http://www.php.net/manual/en/pcntl.constants.php)
454+
* @param int $signal A valid POSIX signal (see https://php.net/pcntl.constants)
455455
*
456456
* @return $this
457457
*
@@ -1578,7 +1578,7 @@ private function resetProcessData()
15781578
/**
15791579
* Sends a POSIX signal to the process.
15801580
*
1581-
* @param int $signal A valid POSIX signal (see http://www.php.net/manual/en/pcntl.constants.php)
1581+
* @param int $signal A valid POSIX signal (see https://php.net/pcntl.constants)
15821582
* @param bool $throwException Whether to throw exception in case signal failed
15831583
*
15841584
* @return bool True if the signal was sent successfully, false otherwise

ProcessUtils.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@ public static function escapeArgument($argument)
4444

4545
//Fix for PHP bug #43784 escapeshellarg removes % from given string
4646
//Fix for PHP bug #49446 escapeshellarg doesn't work on Windows
47-
//@see https://bugs.php.net/bug.php?id=43784
48-
//@see https://bugs.php.net/bug.php?id=49446
47+
//@see https://bugs.php.net/43784
48+
//@see https://bugs.php.net/49446
4949
if ('\\' === \DIRECTORY_SEPARATOR) {
5050
if ('' === $argument) {
5151
return escapeshellarg($argument);

Tests/ProcessTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1178,7 +1178,7 @@ public function pipesCodeProvider()
11781178
];
11791179

11801180
if ('\\' === \DIRECTORY_SEPARATOR) {
1181-
// Avoid XL buffers on Windows because of https://bugs.php.net/bug.php?id=65650
1181+
// Avoid XL buffers on Windows because of https://bugs.php.net/65650
11821182
$sizes = [1, 2, 4, 8];
11831183
} else {
11841184
$sizes = [1, 16, 64, 1024, 4096];

0 commit comments

Comments
 (0)