Skip to content

Commit d0bddb1

Browse files
fjljagdeep sidhu
authored andcommitted
core/types: make "miner" optional in Header JSON (ethereum#24666)
"miner" is not set for pending block responses in some cases. Fixes ethereum#24632
1 parent 111e109 commit d0bddb1

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

core/types/block.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ func (n *BlockNonce) UnmarshalText(input []byte) error {
7676
type Header struct {
7777
ParentHash common.Hash `json:"parentHash" gencodec:"required"`
7878
UncleHash common.Hash `json:"sha3Uncles" gencodec:"required"`
79-
Coinbase common.Address `json:"miner" gencodec:"required"`
79+
Coinbase common.Address `json:"miner"`
8080
Root common.Hash `json:"stateRoot" gencodec:"required"`
8181
TxHash common.Hash `json:"transactionsRoot" gencodec:"required"`
8282
ReceiptHash common.Hash `json:"receiptsRoot" gencodec:"required"`

core/types/gen_header_json.go

Lines changed: 4 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)