Simplify shared cell code

Author: avbdr

PFBC/Element.php

@@ -7,6 +7,7 @@ abstract class Element extends Base {
     protected $label;
     protected $shortDesc;
     protected $longDesc;
+    protected $shared = false;
     protected $validation = array();
 
     public function __construct($label, $name, array $properties = null) {
@@ -49,6 +50,10 @@ public function getLongDesc() {
         return $this->longDesc;
     }
 
+    public function getShared() {
+        return $this->shared;
+    }
+
     /*This method provides a shortcut for checking if an element is required.*/
     public function isRequired() {
         if(!empty($this->validation)) {

PFBC/View/SideBySide.php

@@ -4,6 +4,8 @@ class View_SideBySide extends FormView {
     private $sharedCount = 0;
 
     public function renderElement ($element) {
+        $colSize = 'col-xs-12 col-md-8';
+
         if ($element instanceof Element_Hidden || $element instanceof Element_HTML || $element instanceof Element_Button) {
             $element->render();
             return;
@@ -17,21 +19,19 @@ public function renderElement ($element) {
             $element->setLabel("");
         }
 
-        if (!$element->getAttribute("shared") || $this->sharedCount == 0)
+        if ($this->sharedCount == 0)
             echo '<div class="form-group elem-'.$element->getAttribute("id").'"> ', $this->renderLabel($element);
 
-        $colSize = 'col-xs-12 col-md-8';
-        if ($element->getAttribute ("shared")) {
-            $sharedSize = $element->getAttribute("shared");
-            $this->sharedCount += $sharedSize[strlen($sharedSize) - 1];
-            $colSize = $element->getAttribute ("shared");
+        if ($element->getShared ()) {
+            $colSize = $element->getShared ();
+            $this->sharedCount += $colSize[strlen ($colSize) - 1];
         }
 
         echo " <div class='$colSize'> ";
         echo $element->render(), $this->renderDescriptions($element);
         echo " </div> ";
 
-        if (!$element->getAttribute("shared") || $this->sharedCount == 8) {
+        if ($this->sharedCount == 0 || $this->sharedCount == 8) {
             $this->sharedCount = 0;
             echo " </div> ";
         }

PFBC/View/SideBySide4.php

@@ -3,7 +3,9 @@ class View_SideBySide4 extends FormView {
     private $sharedCount = 0;
 
     public function renderElement ($element) {
+        $colSize = 'col-xs-12 col-md-8';
         $element->bootstrapVersion = 4;
+
         if ($element instanceof Element_Hidden || $element instanceof Element_HTML || $element instanceof Element_Button) {
             $element->render();
             return;
@@ -17,21 +19,19 @@ public function renderElement ($element) {
             $element->setLabel("");
         }
 
-        if (!$element->getAttribute("shared") || $this->sharedCount == 0)
+        if ($this->sharedCount == 0)
             echo '<div class="row form-group elem-'.$element->getAttribute("id").'"> ', $this->renderLabel($element);
 
-        $colSize = 'col-xs-12 col-md-8';
-        if ($element->getAttribute ("shared")) {
-            $sharedSize = $element->getAttribute("shared");
-            $this->sharedCount += $sharedSize[strlen($sharedSize) - 1];
-            $colSize = $element->getAttribute ("shared");
+        if ($element->getShared ()) {
+            $colSize = $element->getShared ();
+            $this->sharedCount += $colSize[strlen ($colSize) - 1];
         }
 
         echo " <div class='$colSize'> ";
         echo $element->render(), $this->renderDescriptions($element);
         echo " </div> ";
 
-        if (!$element->getAttribute("shared") || $this->sharedCount == 8) {
+        if ($this->sharedCount == 0 || $this->sharedCount == 8) {
             $this->sharedCount = 0;
             echo " </div> ";
         }

PFBC/View/Vertical.php

@@ -1,6 +1,7 @@
 <?php
 class View_Vertical extends FormView {
     private $sharedCount = 0;
+
     public function renderElement ($element) {
         if ($element instanceof Element_Hidden || $element instanceof Element_HTML || $element instanceof Element_Button) {
             $element->render();
@@ -9,24 +10,23 @@ public function renderElement ($element) {
         if (!$element instanceof Element_Radio && !$element instanceof Element_Checkbox && !$element instanceof Element_File)
             $element->appendAttribute("class", "form-control");
 
-        if (!$element->getAttribute("shared") || $this->sharedCount == 0) {
-            $rowClass = $element->getAttribute ("shared") ? 'row' : '';
-            echo '<div class="'.$rowClass.' form-group elem-'.$element->getAttribute("id").'"> ', $this->renderLabel($element);
+        if ($this->sharedCount == 0) {
+            $rowClass = $element->getShared() ? 'row' : '';
+            echo '<div class="'.$rowClass.' form-group elem-'.$element->getAttribute ("id").'"> ', $this->renderLabel($element);
         }
 
-        if ($element->getAttribute ("shared")) {
-            $sharedSize = $element->getAttribute("shared");
-            $this->sharedCount += $sharedSize[strlen($sharedSize) - 1];
-            $colSize = $element->getAttribute ("shared");
+        if ($element->getShared()) {
+            $colSize = $element->getShared();
+            $this->sharedCount += $colSize[strlen ($colSize) - 1];
             echo " <div class='$colSize'> ";
         }
 
         $element->setAttribute('placeholder', $element->getLabel());
         echo $element->render(), $this->renderDescriptions($element);
-        if ($element->getAttribute ("shared"))
+        if ($element->getShared())
             echo " </div> ";
 
-        if (!$element->getAttribute("shared") || $this->sharedCount == 12) {
+        if ($this->sharedCount == 0 || $this->sharedCount == 12) {
             $this->sharedCount = 0;
             echo " </div> ";
         }