Merge pull request iluwatar#240 from themoffster/master

iluwatar · iluwatar · commit 0989c9b49886 · 2015-09-05T08:53:05.000+03:00
Improved unit tests so assertions are used.
diff --git a/abstract-factory/src/main/java/com/iluwatar/abstractfactory/App.java b/abstract-factory/src/main/java/com/iluwatar/abstractfactory/App.java
@@ -1,5 +1,6 @@
 package com.iluwatar.abstractfactory;
 
+
 /**
  * 
  * The essence of the Abstract Factory pattern is a factory interface
@@ -12,26 +13,61 @@
  */
 public class App {
 
-	/**
-	 * Program entry point
-	 * @param args command line arguments
-	 */
-	public static void main(String[] args) {
-		createKingdom(new ElfKingdomFactory());
-		createKingdom(new OrcKingdomFactory());
-	}
+	private King king;
+	private Castle castle;
+	private Army army;
 
 	/**
 	 * Creates kingdom
 	 * @param factory
 	 */
-	public static void createKingdom(KingdomFactory factory) {
-		King king = factory.createKing();
-		Castle castle = factory.createCastle();
-		Army army = factory.createArmy();
-		System.out.println("The kingdom was created.");
-		System.out.println(king);
-		System.out.println(castle);
-		System.out.println(army);
+	public void createKingdom(final KingdomFactory factory) {
+		setKing(factory.createKing());
+		setCastle(factory.createCastle());
+		setArmy(factory.createArmy());
+	}
+	
+	ElfKingdomFactory getElfKingdomFactory() {
+		return new ElfKingdomFactory();
+	}
+	
+	OrcKingdomFactory getOrcKingdomFactory() {
+		return new OrcKingdomFactory();
+	}
+	
+	King getKing(final KingdomFactory factory) {
+		return factory.createKing();
+	}
+	
+	Castle getCastle(final KingdomFactory factory) {
+		return factory.createCastle();
+	}
+	
+	Army getArmy(final KingdomFactory factory) {
+		return factory.createArmy();
+	}
+	
+	public King getKing() {
+		return king;
+	}
+	
+	private void setKing(final King king) {
+		this.king = king;
+	}
+	
+	public Castle getCastle() {
+		return castle;
+	}
+	
+	private void setCastle(final Castle castle) {
+		this.castle = castle;
+	}
+	
+	public Army getArmy() {
+		return army;
+	}
+	
+	private void setArmy(final Army army) {
+		this.army = army;
 	}
 }
diff --git a/abstract-factory/src/main/java/com/iluwatar/abstractfactory/Army.java b/abstract-factory/src/main/java/com/iluwatar/abstractfactory/Army.java
@@ -7,4 +7,5 @@
  */
 public interface Army {
 
+	String getDescription();
 }
diff --git a/abstract-factory/src/main/java/com/iluwatar/abstractfactory/Castle.java b/abstract-factory/src/main/java/com/iluwatar/abstractfactory/Castle.java
@@ -7,4 +7,5 @@
  */
 public interface Castle {
 
+	String getDescription();
 }
diff --git a/abstract-factory/src/main/java/com/iluwatar/abstractfactory/ElfArmy.java b/abstract-factory/src/main/java/com/iluwatar/abstractfactory/ElfArmy.java
@@ -7,9 +7,10 @@
  */
 public class ElfArmy implements Army {
 
+	static final String DESCRIPTION = "This is the Elven Army!";
+
 	@Override
-	public String toString() {
-		return "This is the Elven Army!";
+	public String getDescription() {
+		return DESCRIPTION;
 	}
-
 }
diff --git a/abstract-factory/src/main/java/com/iluwatar/abstractfactory/ElfCastle.java b/abstract-factory/src/main/java/com/iluwatar/abstractfactory/ElfCastle.java
@@ -7,9 +7,10 @@
  */
 public class ElfCastle implements Castle {
 
+	static final String DESCRIPTION = "This is the Elven castle!";
+
 	@Override
-	public String toString() {
-		return "This is the Elven castle!";
+	public String getDescription() {
+		return DESCRIPTION;
 	}
-
 }
diff --git a/abstract-factory/src/main/java/com/iluwatar/abstractfactory/ElfKing.java b/abstract-factory/src/main/java/com/iluwatar/abstractfactory/ElfKing.java
@@ -7,9 +7,10 @@
  */
 public class ElfKing implements King {
 
+	static final String DESCRIPTION = "This is the Elven king!";
+	
 	@Override
-	public String toString() {
-		return "This is the Elven king!";
+	public String getDescription() {
+		return DESCRIPTION;
 	}
-
 }
diff --git a/abstract-factory/src/main/java/com/iluwatar/abstractfactory/King.java b/abstract-factory/src/main/java/com/iluwatar/abstractfactory/King.java
@@ -7,4 +7,5 @@
  */
 public interface King {
 
+	String getDescription();
 }
diff --git a/abstract-factory/src/main/java/com/iluwatar/abstractfactory/OrcArmy.java b/abstract-factory/src/main/java/com/iluwatar/abstractfactory/OrcArmy.java
@@ -7,9 +7,10 @@
  */
 public class OrcArmy implements Army {
 
+	static final String DESCRIPTION = "This is the Orc Army!";
+
 	@Override
-	public String toString() {
-		return "This is the Orcish Army!";
+	public String getDescription() {
+		return DESCRIPTION;
 	}
-
 }
diff --git a/abstract-factory/src/main/java/com/iluwatar/abstractfactory/OrcCastle.java b/abstract-factory/src/main/java/com/iluwatar/abstractfactory/OrcCastle.java
@@ -7,9 +7,10 @@
  */
 public class OrcCastle implements Castle {
 
+	static final String DESCRIPTION = "This is the Orc castle!";
+
 	@Override
-	public String toString() {
-		return "This is the Orcish castle!";
+	public String getDescription() {
+		return DESCRIPTION;
 	}
-
 }
diff --git a/abstract-factory/src/main/java/com/iluwatar/abstractfactory/OrcKing.java b/abstract-factory/src/main/java/com/iluwatar/abstractfactory/OrcKing.java
@@ -7,9 +7,10 @@
  */
 public class OrcKing implements King {
 
+static final String DESCRIPTION = "This is the Orc king!";
+	
 	@Override
-	public String toString() {
-		return "This is the Orc king!";
+	public String getDescription() {
+		return DESCRIPTION;
 	}
-
 }
diff --git a/abstract-factory/src/test/java/com/iluwatar/abstractfactory/AppTest.java b/abstract-factory/src/test/java/com/iluwatar/abstractfactory/AppTest.java
@@ -1,18 +1,77 @@
 package com.iluwatar.abstractfactory;
-import org.junit.Test;
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
 
-import com.iluwatar.abstractfactory.App;
+import org.junit.Before;
+import org.junit.Test;
 
-/**
- * 
- * Application test
- *
- */
 public class AppTest {
 
+	private App app = new App();;
+	private KingdomFactory elfFactory;
+	private KingdomFactory orcFactory;
+	
+	@Before
+	public void setUp() {
+		elfFactory = app.getElfKingdomFactory();
+		orcFactory = app.getOrcKingdomFactory();
+	}
+	
+	@Test
+	public void king() {
+		final King elfKing = app.getKing(elfFactory);
+		assertTrue(elfKing instanceof ElfKing);
+		assertEquals(ElfKing.DESCRIPTION, elfKing.getDescription());
+		final King orcKing = app.getKing(orcFactory);
+		assertTrue(orcKing instanceof OrcKing);
+		assertEquals(OrcKing.DESCRIPTION, orcKing.getDescription());
+	}
+	
+	@Test
+	public void castle() {
+		final Castle elfCastle = app.getCastle(elfFactory);
+		assertTrue(elfCastle instanceof ElfCastle);
+		assertEquals(ElfCastle.DESCRIPTION, elfCastle.getDescription());
+		final Castle orcCastle = app.getCastle(orcFactory);
+		assertTrue(orcCastle instanceof OrcCastle);
+		assertEquals(OrcCastle.DESCRIPTION, orcCastle.getDescription());
+	}
+	
+	@Test
+	public void army() {
+		final Army elfArmy = app.getArmy(elfFactory);
+		assertTrue(elfArmy instanceof ElfArmy);
+		assertEquals(ElfArmy.DESCRIPTION, elfArmy.getDescription());
+		final Army orcArmy = app.getArmy(orcFactory);
+		assertTrue(orcArmy instanceof OrcArmy);
+		assertEquals(OrcArmy.DESCRIPTION, orcArmy.getDescription());
+	}
+	
+	@Test
+	public void createElfKingdom() {
+		app.createKingdom(elfFactory);
+		final King king = app.getKing();
+		final Castle castle = app.getCastle();
+		final Army army = app.getArmy();
+		assertTrue(king instanceof ElfKing);
+		assertEquals(ElfKing.DESCRIPTION, king.getDescription());
+		assertTrue(castle instanceof ElfCastle);
+		assertEquals(ElfCastle.DESCRIPTION, castle.getDescription());
+		assertTrue(army instanceof ElfArmy);
+		assertEquals(ElfArmy.DESCRIPTION, army.getDescription());
+	}
+	
 	@Test
-	public void test() {
-		String[] args = {};
-		App.main(args);
+	public void createOrcKingdom() {
+		app.createKingdom(orcFactory);
+		final King king = app.getKing();
+		final Castle castle = app.getCastle();
+		final Army army = app.getArmy();
+		assertTrue(king instanceof OrcKing);
+		assertEquals(OrcKing.DESCRIPTION, king.getDescription());
+		assertTrue(castle instanceof OrcCastle);
+		assertEquals(OrcCastle.DESCRIPTION, castle.getDescription());
+		assertTrue(army instanceof OrcArmy);
+		assertEquals(OrcArmy.DESCRIPTION, army.getDescription());
 	}
 }

Original file line number	Diff line number	Diff line change
`@@ -7,4 +7,5 @@`
`7`	`7`	`*/`
`8`	`8`	`public interface Army {`
`9`	`9`
	`10`	`+ String getDescription();`
`10`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,4 +7,5 @@`
`7`	`7`	`*/`
`8`	`8`	`public interface Castle {`
`9`	`9`
	`10`	`+ String getDescription();`
`10`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,9 +7,10 @@`
`7`	`7`	`*/`
`8`	`8`	`public class ElfArmy implements Army {`
`9`	`9`
	`10`	`+ static final String DESCRIPTION = "This is the Elven Army!";`
	`11`	`+`
`10`	`12`	`@Override`
`11`		`- public String toString() {`
`12`		`- return "This is the Elven Army!";`
	`13`	`+ public String getDescription() {`
	`14`	`+ return DESCRIPTION;`
`13`	`15`	`}`
`14`		`-`
`15`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,9 +7,10 @@`
`7`	`7`	`*/`
`8`	`8`	`public class ElfCastle implements Castle {`
`9`	`9`
	`10`	`+ static final String DESCRIPTION = "This is the Elven castle!";`
	`11`	`+`
`10`	`12`	`@Override`
`11`		`- public String toString() {`
`12`		`- return "This is the Elven castle!";`
	`13`	`+ public String getDescription() {`
	`14`	`+ return DESCRIPTION;`
`13`	`15`	`}`
`14`		`-`
`15`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,9 +7,10 @@`
`7`	`7`	`*/`
`8`	`8`	`public class ElfKing implements King {`
`9`	`9`
	`10`	`+ static final String DESCRIPTION = "This is the Elven king!";`
	`11`	`+`
`10`	`12`	`@Override`
`11`		`- public String toString() {`
`12`		`- return "This is the Elven king!";`
	`13`	`+ public String getDescription() {`
	`14`	`+ return DESCRIPTION;`
`13`	`15`	`}`
`14`		`-`
`15`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,4 +7,5 @@`
`7`	`7`	`*/`
`8`	`8`	`public interface King {`
`9`	`9`
	`10`	`+ String getDescription();`
`10`	`11`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,9 +7,10 @@`
`7`	`7`	`*/`
`8`	`8`	`public class OrcArmy implements Army {`
`9`	`9`
	`10`	`+ static final String DESCRIPTION = "This is the Orc Army!";`
	`11`	`+`
`10`	`12`	`@Override`
`11`		`- public String toString() {`
`12`		`- return "This is the Orcish Army!";`
	`13`	`+ public String getDescription() {`
	`14`	`+ return DESCRIPTION;`
`13`	`15`	`}`
`14`		`-`
`15`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,9 +7,10 @@`
`7`	`7`	`*/`
`8`	`8`	`public class OrcCastle implements Castle {`
`9`	`9`
	`10`	`+ static final String DESCRIPTION = "This is the Orc castle!";`
	`11`	`+`
`10`	`12`	`@Override`
`11`		`- public String toString() {`
`12`		`- return "This is the Orcish castle!";`
	`13`	`+ public String getDescription() {`
	`14`	`+ return DESCRIPTION;`
`13`	`15`	`}`
`14`		`-`
`15`	`16`	`}`
Original file line number	Diff line number	Diff line change
`@@ -7,9 +7,10 @@`
`7`	`7`	`*/`
`8`	`8`	`public class OrcKing implements King {`
`9`	`9`
	`10`	`+static final String DESCRIPTION = "This is the Orc king!";`
	`11`	`+`
`10`	`12`	`@Override`
`11`		`- public String toString() {`
`12`		`- return "This is the Orc king!";`
	`13`	`+ public String getDescription() {`
	`14`	`+ return DESCRIPTION;`
`13`	`15`	`}`
`14`		`-`
`15`	`16`	`}`