Try matrix, cleanup tarantool

Author: DifferentialOrange

.github/workflows/testing.yml

@@ -21,23 +21,38 @@ jobs:
       matrix:
         tarantool:
           - '1.10'
-          # - '2.8'
-          # - '2.9'
+          - '2.8'
+          - '2.9'
           - '2.x-latest'
         python:
           - '2.7'
-          # - '3.5'
-          # - '3.6'
-          # - '3.7'
-          # - '3.8'
-          # - '3.9'
+          - '3.5'
+          - '3.6'
+          - '3.7'
+          - '3.8'
+          - '3.9'
           - '3.10'
         msgpack-deps:
-          - 'msgpack-python==0.4.0'
-          - 'msgpack==0.5.0'
-          - 'msgpack==0.6.2'
-          - 'msgpack==1.0.0'
-          - 'msgpack>=0.4.0'
+          # latest msgpack will be installed as a part of requirements.txt
+          - ''
+
+        # Adding too many elements in three-dimentional matrix results in
+        # too many test cases, which causes GitHub webpages to fail with 
+        # "This page is taking too long to load." error, so we use pairwise
+        # testing. 
+        include:
+          - tarantool: '2.8'
+            python: '3.10'
+            msgpack-deps: 'msgpack-python==0.4.0'
+          - tarantool: '2.8'
+            python: '3.10'
+            msgpack-deps: 'msgpack==0.5.0'
+          - tarantool: '2.8'
+            python: '3.10'
+            msgpack-deps: 'msgpack==0.6.2'
+          - tarantool: '2.8'
+            python: '3.10'
+            msgpack-deps: 'msgpack==1.0.0'
 
     steps:
       - name: Clone the connector
@@ -55,15 +70,21 @@ jobs:
           curl -L https://tarantool.io/pre-release/2/installer.sh | sudo bash
           sudo apt install -y tarantool tarantool-dev
 
-      - name: Setup python3 for tests
+      - name: Setup Python for tests
         uses: actions/setup-python@v2
         with:
           python-version: ${{ matrix.python }}
 
-      - name: Setup msgpack python package
+      - name: Setup specific msgpack python package
+        if: matrix.msgpack-deps != ''
         run: pip install ${{ matrix.msgpack-deps }}
 
       - name: Install connector requirements
+        # msgpack package is a replacement for deprecated msgpack-python.
+        # To test compatibility with msgpack-python we must ignore
+        # requirements.txt install, since it will install newest msgpack.
+        # Beware that if any new dependency will be added to requirements.txt,
+        # this step will be invalid.
         if: matrix.msgpack-deps != 'msgpack-python==0.4.0'
         run: pip install -r requirements.txt
 
@@ -87,6 +108,11 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
+        tarantool:
+          - '1.10'
+          - '2.8'
+          - '2.9'
+          - '2.x-latest'
         python:
           - '2.7'
           - '3.5'
@@ -95,46 +121,67 @@ jobs:
           - '3.8'
           - '3.9'
           - '3.10'
-        python-msgpack:
-          - '0.5.0'
-          - '0.6.2'
-          - '1.0.0'
-          - 'latest'
+        msgpack-deps:
+          # latest msgpack will be installed as a part of requirements.txt
+          - ''
+
+        # Adding too many elements in three-dimentional matrix results in
+        # too many test cases, which causes GitHub webpages to fail with 
+        # "This page is taking too long to load." error, so we use pairwise
+        # testing. 
+        include:
+          - tarantool: '2.8'
+            python: '3.10'
+            msgpack-deps: 'msgpack-python==0.4.0'
+          - tarantool: '2.8'
+            python: '3.10'
+            msgpack-deps: 'msgpack==0.5.0'
+          - tarantool: '2.8'
+            python: '3.10'
+            msgpack-deps: 'msgpack==0.6.2'
+          - tarantool: '2.8'
+            python: '3.10'
+            msgpack-deps: 'msgpack==1.0.0'
 
     steps:
       - name: Clone the connector
         uses: actions/checkout@v2
 
-      - name: Setup python3 for tests
+      - name: Setup Python for tests
         uses: actions/setup-python@v2
         with:
           python-version: ${{ matrix.python }}
 
-      - name: Setup msgpack python package
-        if: matrix.python-msgpack != 'latest'
-        # 'latest' msgpack will be installed as a part of requirements.txt
-        run: pip install msgpack==${{ matrix.python-msgpack }}
+      - name: Setup specific msgpack python package
+        if: matrix.msgpack-deps != ''
+        run: pip install ${{ matrix.msgpack-deps }}
 
       - name: Install connector requirements
+        # msgpack package is a replacement for deprecated msgpack-python.
+        # To test compatibility with msgpack-python we must ignore
+        # requirements.txt install, since it will install newest msgpack.
+        # Beware that if any new dependency will be added to requirements.txt,
+        # this step will be invalid.
+        if: matrix.msgpack-deps != 'msgpack-python==0.4.0'
         run: pip install -r requirements.txt
 
       - name: Install test requirements
         run: pip install -r requirements-test.txt
 
-      - name: Setup WSL
+      - name: Setup WSL for test Tarantool
         uses: Vampire/setup-wsl@v1
         with:
           distribution: Ubuntu-20.04
 
-      - shell: wsl-bash_Ubuntu-20.04 {0}
+      - name: Setup test Tarantool
+        shell: wsl-bash_Ubuntu-20.04 {0}
         run: |
           curl -L https://tarantool.io/pre-release/2/installer.sh | sudo bash
           sudo apt install -y tarantool tarantool-dev
-          tarantool ./test/suites/lib/tarantool_python_ci.lua &
-          sudo apt-get install net-tools -y
-          netstat -a
-
-      - run: netstat -a
+          TNT_PID=$(tarantool ./test/suites/lib/tarantool_python_ci.lua > tarantool.log 2>&1 & echo $!)
+          echo "::save-state name=TNT_PID::$TNT_PID"
+        post-if: process.env.STATE_TNT_PID != ''
+        post: kill $STATE_TNT_PID
 
       - name: Run tests
         env:

requirements.txt

@@ -1 +1 @@
-msgpack-python>=0.4.0
+msgpack>=0.4.0