Skip to content

Commit 686966a

Browse files
committed
Fixed the application_controller require_dependency path generated by the app generator
1 parent 870310d commit 686966a

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

railties/lib/rails/generators/named_base.rb

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,10 +84,11 @@ def namespaced_file_path
8484
end
8585

8686
def namespaced_class_path
87-
@namespaced_class_path ||= begin
88-
namespace_path = namespace.name.split("::").map {|m| m.underscore }
89-
namespace_path + @class_path
90-
end
87+
@namespaced_class_path ||= [namespace_path] + @class_path
88+
end
89+
90+
def namespace_path
91+
@namespace_path ||= namespace.name.split("::").map {|m| m.underscore }[0]
9192
end
9293

9394
def class_name

railties/lib/rails/generators/rails/controller/templates/controller.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
<% if namespaced? -%>
2-
require_dependency "<%= namespaced_file_path %>/application_controller"
2+
require_dependency "<%= namespace_path %>/application_controller"
33
44
<% end -%>
55
<% module_namespacing do -%>

railties/test/generators/namespaced_generators_test.rb

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,9 @@ def test_skipping_namespace
3838

3939
def test_namespaced_controller_with_additional_namespace
4040
run_generator ["admin/account"]
41-
assert_file "app/controllers/test_app/admin/account_controller.rb", /module TestApp/, / class Admin::AccountController < ApplicationController/
41+
assert_file "app/controllers/test_app/admin/account_controller.rb", /module TestApp/, / class Admin::AccountController < ApplicationController/ do |contents|
42+
assert_match %r(require_dependency "test_app/application_controller"), contents
43+
end
4244
end
4345

4446
def test_helpr_is_also_namespaced

0 commit comments

Comments
 (0)