Skip to content

Commit 018b4db

Browse files
fix(bundler): skip signing for nsis uninstaller on --no-sign (#14625)
1 parent 731dd5b commit 018b4db

File tree

3 files changed

+12
-3
lines changed

3 files changed

+12
-3
lines changed
Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
tauri-bundler: patch:bug
3+
---
4+
5+
Skip signing for NSIS uninstaller when using `--no-sign` flag

crates/tauri-bundler/src/bundle.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -273,7 +273,7 @@ fn sign_binaries_if_needed(settings: &Settings, target_os: &TargetPlatform) -> c
273273
if matches!(target_os, TargetPlatform::Windows) {
274274
if settings.windows().can_sign() {
275275
if settings.no_sign() {
276-
log::info!("Skipping binary signing due to --no-sign flag.");
276+
log::warn!("Skipping binary signing due to --no-sign flag.");
277277
return Ok(());
278278
}
279279

crates/tauri-bundler/src/bundle/windows/nsis/mod.rs

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -298,8 +298,12 @@ fn build_nsis_app_installer(
298298
data.insert("copyright", to_json(settings.copyright_string()));
299299

300300
if settings.windows().can_sign() {
301-
let sign_cmd = format!("{:?}", sign_command("%1", &settings.sign_params())?);
302-
data.insert("uninstaller_sign_cmd", to_json(sign_cmd));
301+
if settings.no_sign() {
302+
log::warn!("Skipping signing for NSIS uninstaller due to --no-sign flag.");
303+
} else {
304+
let sign_cmd = format!("{:?}", sign_command("%1", &settings.sign_params())?);
305+
data.insert("uninstaller_sign_cmd", to_json(sign_cmd));
306+
}
303307
}
304308

305309
let version = settings.version_string();

0 commit comments

Comments
 (0)