From 7443e4febe5ba03c9e03517ee12601f2368d4e62 Mon Sep 17 00:00:00 2001 From: Tony Date: Mon, 8 Dec 2025 10:57:40 +0800 Subject: [PATCH] fix(bundler): skip signing for nsis uninstaller on `--no-sign` --- .changes/no-sign-skip-nsis-uninstaller.md | 5 +++++ crates/tauri-bundler/src/bundle.rs | 2 +- crates/tauri-bundler/src/bundle/windows/nsis/mod.rs | 8 ++++++-- 3 files changed, 12 insertions(+), 3 deletions(-) create mode 100644 .changes/no-sign-skip-nsis-uninstaller.md diff --git a/.changes/no-sign-skip-nsis-uninstaller.md b/.changes/no-sign-skip-nsis-uninstaller.md new file mode 100644 index 000000000000..3e7952d934bc --- /dev/null +++ b/.changes/no-sign-skip-nsis-uninstaller.md @@ -0,0 +1,5 @@ +--- +tauri-bundler: patch:bug +--- + +Skip signing for NSIS uninstaller when using `--no-sign` flag diff --git a/crates/tauri-bundler/src/bundle.rs b/crates/tauri-bundler/src/bundle.rs index 654ad5647401..bac77c041f04 100644 --- a/crates/tauri-bundler/src/bundle.rs +++ b/crates/tauri-bundler/src/bundle.rs @@ -273,7 +273,7 @@ fn sign_binaries_if_needed(settings: &Settings, target_os: &TargetPlatform) -> c if matches!(target_os, TargetPlatform::Windows) { if settings.windows().can_sign() { if settings.no_sign() { - log::info!("Skipping binary signing due to --no-sign flag."); + log::warn!("Skipping binary signing due to --no-sign flag."); return Ok(()); } diff --git a/crates/tauri-bundler/src/bundle/windows/nsis/mod.rs b/crates/tauri-bundler/src/bundle/windows/nsis/mod.rs index 8b2bc4eef858..f456ed97a190 100644 --- a/crates/tauri-bundler/src/bundle/windows/nsis/mod.rs +++ b/crates/tauri-bundler/src/bundle/windows/nsis/mod.rs @@ -298,8 +298,12 @@ fn build_nsis_app_installer( data.insert("copyright", to_json(settings.copyright_string())); if settings.windows().can_sign() { - let sign_cmd = format!("{:?}", sign_command("%1", &settings.sign_params())?); - data.insert("uninstaller_sign_cmd", to_json(sign_cmd)); + if settings.no_sign() { + log::warn!("Skipping signing for NSIS uninstaller due to --no-sign flag."); + } else { + let sign_cmd = format!("{:?}", sign_command("%1", &settings.sign_params())?); + data.insert("uninstaller_sign_cmd", to_json(sign_cmd)); + } } let version = settings.version_string();