Skip to content

Commit 98dcaa2

Browse files
committed
PYTHON-1056 - Disallow double quotes in database names
1 parent 1d81aea commit 98dcaa2

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

pymongo/database.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ def _check_name(name):
4141
if not name:
4242
raise InvalidName("database name cannot be the empty string")
4343

44-
for invalid_char in [" ", ".", "$", "/", "\\", "\x00"]:
44+
for invalid_char in [' ', '.', '$', '/', '\\', '\x00', '"']:
4545
if invalid_char in name:
4646
raise InvalidName("database names cannot contain the "
4747
"character %r" % invalid_char)

test/test_database.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -71,6 +71,7 @@ def setUpClass(cls):
7171
def test_name(self):
7272
self.assertRaises(TypeError, Database, self.client, 4)
7373
self.assertRaises(InvalidName, Database, self.client, "my db")
74+
self.assertRaises(InvalidName, Database, self.client, 'my"db')
7475
self.assertRaises(InvalidName, Database, self.client, "my\x00db")
7576
self.assertRaises(InvalidName, Database,
7677
self.client, u("my\u0000db"))

0 commit comments

Comments
 (0)