[webgpu] Add unpack #4789
Merged
[webgpu] Add unpack #4789
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@gyagp @qjia7 @haoyunfeix @xhcao PTAL. |
qjia7
reviewed
Mar 9, 2021
| toDispose.push(sliced); | ||
| } | ||
|
|
||
| toDispose.forEach(t => backend.disposeData(t)); |
Contributor
There was a problem hiding this comment.
backend.disposeData(t.dataId)
Contributor
There was a problem hiding this comment.
I just found in the Pack implementation. You also used backend.disposeData(t) not backend.disposeData(t.dataId). Please change that part too. Otherwise, it may result memory leak.
Contributor
Author
There was a problem hiding this comment.
Great catch! Thanks Jiajia, updated, PTAL
FEATURE
lina128
approved these changes
Mar 9, 2021
Collaborator
lina128
left a comment
lina128
left a comment
There was a problem hiding this comment.
LGTM
Reviewable status:
complete! 2 of 1 approvals obtained (waiting on @qjia7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FEATURE
This change is