Resolve gcc "warning: comparison between signed and unsigned integer expressions [-Wsign-compare]"

garethsb · garethsb · commit 8bd803235f5e · 2017-11-03T12:05:35.000Z
diff --git a/Release/include/cpprest/filestream.h b/Release/include/cpprest/filestream.h
@@ -360,7 +360,7 @@ namespace details {
 
             size_t written = _putn_fsb(m_info, callback, ptr, count, sizeof(_CharType));
 
-            if ( written != 0 && written != -1 )
+            if ( written != 0 && written != size_t(-1) )
             {
                 delete callback;
                 written = written/sizeof(_CharType);
@@ -572,7 +572,7 @@ namespace details {
 
                 size_t read = _getn_fsb(m_info, callback, ptr, count, sizeof(_CharType));
 
-                if ( read != 0 && read != -1)
+                if ( read != 0 && read != size_t(-1) )
                 {
                     delete callback;
                     pplx::extensibility::scoped_recursive_lock_t lck(m_info->m_lock);

Original file line number	Diff line number	Diff line change
`@@ -360,7 +360,7 @@ namespace details {`
`360`	`360`
`361`	`361`	`size_t written = _putn_fsb(m_info, callback, ptr, count, sizeof(_CharType));`
`362`	`362`
`363`		`- if ( written != 0 && written != -1 )`
	`363`	`+ if ( written != 0 && written != size_t(-1) )`
`364`	`364`	`{`
`365`	`365`	`delete callback;`
`366`	`366`	`written = written/sizeof(_CharType);`
`@@ -572,7 +572,7 @@ namespace details {`
`572`	`572`
`573`	`573`	`size_t read = _getn_fsb(m_info, callback, ptr, count, sizeof(_CharType));`
`574`	`574`
`575`		`- if ( read != 0 && read != -1)`
	`575`	`+ if ( read != 0 && read != size_t(-1) )`
`576`	`576`	`{`
`577`	`577`	`delete callback;`
`578`	`578`	`pplx::extensibility::scoped_recursive_lock_t lck(m_info->m_lock);`