Skip to content

Commit af02b4d

Browse files
committed
Store: irate and resets use now counter downsampling aggregations.
See related discussion: https://cloud-native.slack.com/archives/CL25937SP/p1590408991325100 Signed-off-by: Bartlomiej Plotka <bwplotka@gmail.com>
1 parent ae589a1 commit af02b4d

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ We use *breaking* word for marking changes that are not backward compatible (rel
2828
- [#2525](https://github.com/thanos-io/thanos/pull/2525) Query: Fixed logging for dns resolution error in the `Query` component.
2929
- [#2484](https://github.com/thanos-io/thanos/pull/2484) Query/Ruler: Fixed issue #2483, when web.route-prefix is set, it is added twice in HTTP router prefix.
3030
- [#2416](https://github.com/thanos-io/thanos/pull/2416) Bucket: Fixed issue #2416 bug in `inspect --sort-by` doesn't work correctly in all cases
31+
- [#2719](https://github.com/thanos-io/thanos/pull/2719) Store: `irate` and `resets` use now counter downsampling aggregations.
3132

3233
### Added
3334

pkg/query/querier.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -153,7 +153,7 @@ func aggrsFromFunc(f string) []storepb.Aggr {
153153
if strings.HasPrefix(f, "sum_") {
154154
return []storepb.Aggr{storepb.Aggr_SUM}
155155
}
156-
if f == "increase" || f == "rate" {
156+
if f == "increase" || f == "rate" || f == "irate" || f == "resets" {
157157
return []storepb.Aggr{storepb.Aggr_COUNTER}
158158
}
159159
// In the default case, we retrieve count and sum to compute an average.

0 commit comments

Comments
 (0)