Allow specifying the path to libquickjs.a #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolreader18
force-pushed
the
specify-lib-path
branch
from
c8de0c9 to
13e2724
Compare
coolreader18
force-pushed
the
specify-lib-path
branch
from
13e2724 to
f938053
Compare
theduke
reviewed
Apr 30, 2020
Owner
theduke
left a comment
theduke
left a comment
There was a problem hiding this comment.
Hey, thanks.
I had wanted to do this initially, but then never used a non-bundled installation.
Just a small suggestion for wording and changing the env var name to something more similar to the standard LIBRARY_PATH.
Co-authored-by: theduke <[email protected]>
Owner
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also updated the embedded quickjs version.nevermind, it broke the build.