From fd207c41398a469ebca01bbe7ad7c0284a54d218 Mon Sep 17 00:00:00 2001 From: Andres Portillo Date: Thu, 7 Nov 2019 18:33:53 -0800 Subject: [PATCH 1/2] Add class variable USE_UNIQUE_DUPLICATE_SUFFIX --- model_clone/mixins/clone.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/model_clone/mixins/clone.py b/model_clone/mixins/clone.py index 121373c1..662d6098 100644 --- a/model_clone/mixins/clone.py +++ b/model_clone/mixins/clone.py @@ -37,6 +37,7 @@ class TestModel(CloneMixin, models.Model): _clonable_one_to_one_fields = [] UNIQUE_DUPLICATE_SUFFIX = 'copy' + USE_UNIQUE_DUPLICATE_SUFFIX = True @property @abc.abstractmethod @@ -75,8 +76,9 @@ def _create_copy_of_instance(cls, instance): .filter(**{'{}__startswith'.format(f.attname): value}) .count() ) - if not str(value).isdigit(): - value += ' {} {}'.format(cls.UNIQUE_DUPLICATE_SUFFIX, count) + if cls.USE_UNIQUE_DUPLICATE_SUFFIX is True: + if not str(value).isdigit(): + value += ' {} {}'.format(cls.UNIQUE_DUPLICATE_SUFFIX, count) if isinstance(f, SlugField): value = slugify(value) defaults[f.attname] = value From 6d11bd1ae43d395ec08e6764cdf7cff597b79f54 Mon Sep 17 00:00:00 2001 From: Andres Portillo Date: Fri, 8 Nov 2019 17:17:59 -0800 Subject: [PATCH 2/2] Change comparison to check for any truthy value --- model_clone/mixins/clone.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/model_clone/mixins/clone.py b/model_clone/mixins/clone.py index 662d6098..302b78bb 100644 --- a/model_clone/mixins/clone.py +++ b/model_clone/mixins/clone.py @@ -76,7 +76,7 @@ def _create_copy_of_instance(cls, instance): .filter(**{'{}__startswith'.format(f.attname): value}) .count() ) - if cls.USE_UNIQUE_DUPLICATE_SUFFIX is True: + if cls.USE_UNIQUE_DUPLICATE_SUFFIX: if not str(value).isdigit(): value += ' {} {}'.format(cls.UNIQUE_DUPLICATE_SUFFIX, count) if isinstance(f, SlugField):