Add OwnedRwLockReadGuard and OwnedRwLockWriteGuard #3340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
I've rebased on #3348 now. |
I did not add mapping functions as it's not possible to implement them soundly without adding another generic parameter to the guards, which I will leave to another PR. Fixes: tokio-rs#3327
SabrinaJewson
force-pushed
the
master
branch
from
0d64150 to
67244da
Compare
Contributor
Author
|
After another rebase, it should finally be good to review now. I didn't choose the best of times to make this PR 😅. |
Darksonn
reviewed
Feb 13, 2021
Darksonn
reviewed
Mar 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did not add mapping functions as it's not possible to implement them soundly without adding another generic parameter to the guards, which I will leave to another PR. I implemented
OwnedRwLockWriteGuard::downgradeas a method becauseRwLockWriteGuard::downgradeis a method - but that was probably a mistake, so I'm not sure.Fixes: #3327
Motivation
The feature is already present for mutexes, and it is useful in some scenarios with
RwLocks.Solution
Add
OwnedRwLockReadGuardandOwnedRwLockWriteGuard, which are variants ofRwLockReadGuardandRwLockWriteGuardthat store anArc.