Skip to content

Commit 3469a08

Browse files
authored
Merge pull request metacpan#757 from metacpan/mickey/sort_param_fix_for_requires
Reuse the 'sort' param value fix in calls to 'requires'
2 parents 9549422 + c56129a commit 3469a08

File tree

1 file changed

+16
-7
lines changed
  • lib/MetaCPAN/Document/Release

1 file changed

+16
-7
lines changed

lib/MetaCPAN/Document/Release/Set.pm

Lines changed: 16 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -606,7 +606,8 @@ sub requires {
606606
my ( $self, $module, $page, $page_size, $sort ) = @_;
607607
$page //= 1;
608608
$page_size //= 20;
609-
$sort //= { date => 'desc' };
609+
610+
_fix_sort_value( \$sort );
610611

611612
my $query = {
612613
query => {
@@ -720,17 +721,25 @@ sub _get_provided_modules {
720721
];
721722
}
722723

724+
sub _fix_sort_value {
725+
my $sort = shift;
726+
727+
if ( ${$sort} =~ /^(\w+):(asc|desc)$/ ) {
728+
${$sort} = { $1 => $2 };
729+
}
730+
else {
731+
${$sort} = { date => 'desc' };
732+
}
733+
734+
return;
735+
}
736+
723737
sub _get_depended_releases {
724738
my ( $self, $modules, $page, $page_size, $sort ) = @_;
725739
$page //= 1;
726740
$page_size //= 50;
727741

728-
if ( $sort =~ /^(\w+):(asc|desc)$/ ) {
729-
$sort = { $1 => $2 };
730-
}
731-
else {
732-
$sort = { date => 'desc' };
733-
}
742+
_fix_sort_value( \$sort );
734743

735744
# because 'terms' doesn't work properly
736745
my $filter_modules = {

0 commit comments

Comments
 (0)