Skip to content

Commit 885115c

Browse files
committed
SDK changes to make sdk pending approval work
Reviewers: arik, benchan Reviewed By: benchan Subscribers: ben Differential Revision: https://phabricator.bitgo.com/D5840
1 parent cd29d1c commit 885115c

File tree

2 files changed

+5
-2
lines changed

2 files changed

+5
-2
lines changed

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "bitgo",
3-
"version": "3.4.1",
3+
"version": "3.4.2",
44
"description": "BitGo Javascript SDK",
55
"main": "./src/index.js",
66
"keywords": [

src/v2/pendingApproval.js

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,11 +201,13 @@ PendingApproval.prototype.approve = function(params, callback) {
201201
}
202202
})
203203
.then(function(transaction) {
204-
205204
var approvalParams = { 'state': 'approved', 'otp': params.otp };
206205
if (transaction) {
207206
// if in the previous instance, we recreated a transaction, we need to add its hex to the approval params
208207
approvalParams.txHex = transaction.txHex;
208+
if (transaction.halfSigned) {
209+
approvalParams.halfSigned = transaction.halfSigned;
210+
}
209211
}
210212
return self.bitgo.put(self.url())
211213
.send(approvalParams)
@@ -267,6 +269,7 @@ PendingApproval.prototype.recreateAndSignTransaction = function(params) {
267269
return Q.all([txPrebuildPromise, userKeychainPromise])
268270
.spread(function(txPrebuild, userKeychain) {
269271
var signingParams = _.extend({}, params, { txPrebuild: txPrebuild, keychain: userKeychain });
272+
signingParams.recipients = recipients;
270273
return wallet.signTransaction(signingParams);
271274
});
272275
};

0 commit comments

Comments
 (0)