Fixed issue phpredis#68.

Author: nicolasff

redis.c

@@ -852,18 +852,36 @@ PHP_METHOD(Redis, getMultiple)
                                        &pointer) == SUCCESS;
          zend_hash_move_forward_ex(arr_hash, &pointer)) {
 
+        char *key;
+        int key_len;
+        zval *z_tmp = NULL;
+
         if (Z_TYPE_PP(data) == IS_STRING) {
-            char *old_cmd = NULL;
-            if(*cmd) {
-                old_cmd = cmd;
-            }
-            cmd_len = redis_cmd_format(&cmd, "%s$%d" _NL "%s" _NL
-                            , cmd, cmd_len
-                            , Z_STRLEN_PP(data), Z_STRVAL_PP(data), Z_STRLEN_PP(data));
-            if(old_cmd) {
-                efree(old_cmd);
-            }
-            elements++;
+            key = Z_STRVAL_PP(data);
+            key_len = Z_STRLEN_PP(data);
+        } else { /* not a string, copy and convert. */
+            MAKE_STD_ZVAL(z_tmp);
+            *z_tmp = **data;
+            zval_copy_ctor(z_tmp);
+            convert_to_string(z_tmp);
+
+            key = Z_STRVAL_P(z_tmp);
+            key_len = Z_STRLEN_P(z_tmp);
+        }
+        char *old_cmd = NULL;
+        if(*cmd) {
+            old_cmd = cmd;
+        }
+        cmd_len = redis_cmd_format(&cmd, "%s$%d" _NL "%s" _NL
+                        , cmd, cmd_len
+                        , key_len, key, key_len);
+        if(old_cmd) {
+            efree(old_cmd);
+        }
+        elements++;
+        if(z_tmp) {
+            zval_dtor(z_tmp);
+            efree(z_tmp);
         }
     }
 

tests/TestRedis.php

@@ -211,6 +211,7 @@ public function testMultiple() {
 	$this->redis->set('k1', 'v1');
 	$this->redis->set('k2', 'v2');
 	$this->redis->set('k3', 'v3');
+	$this->redis->set(1, 'test');
 
 	$this->assertEquals(array('v1'), $this->redis->getMultiple(array('k1')));
 	$this->assertEquals(array('v1', 'v3', false), $this->redis->getMultiple(array('k1', 'k3', 'NoKey')));
@@ -219,6 +220,8 @@ public function testMultiple() {
 
 	$this->redis->set('k5', '$1111111111');
 	$this->assertEquals(array(0 => '$1111111111'), $this->redis->getMultiple(array('k5')));
+
+	$this->assertEquals(array(0 => 'test'), $this->redis->getMultiple(array(1))); // non-string
     }
 
     public function testMultipleBin() {