Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: trifectatechfoundation/bzip2-rs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.5.0
Choose a base ref
...
head repository: trifectatechfoundation/bzip2-rs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.5.1
Choose a head ref
  • 18 commits
  • 9 files changed
  • 7 contributors

Commits on Dec 16, 2024

  1. write::BzDecoder: Fix infinite loop on drop when no data is read or w…

    …ritten
    
    If writes to the BzDecoder end before it has been fed the entire stream
    and the output buffer has already been flushed to the wrapped writer,
    then the Drop implementation will loop forever. On drop, try_finish() is
    called, which repeatedly tries to write() until BZ_STREAM_END is
    returned or an error occurs, but neither scenario happens if there's no
    input nor output data to process.
    
    This commit makes try_finish() return an UnexpectedEof error in this
    scenario.
    
    Signed-off-by: Andrew Gunnerson <accounts+github@chiller3.com>
    chenxiaolong authored and folkertdev committed Dec 16, 2024
    Configuration menu
    Copy the full SHA
    0523b92 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    130c589 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    66b6f7e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    fa38606 View commit details
    Browse the repository at this point in the history
  5. fix typo

    Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>
    folkertdev and bjorn3 committed Dec 16, 2024
    Configuration menu
    Copy the full SHA
    427c709 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    15b56b6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    15258fe View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2024

  1. use core::ffi::{c_int, c_uint} in favor of libc

    libc does not expose those types for some targets (notable wasm32-unknown-unknown)
    folkertdev committed Dec 27, 2024
    Configuration menu
    Copy the full SHA
    3f84eaf View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2025

  1. Add finisher drop implementation to BzEncoder

    This ensures that finish will always be attempted to be called, for
    example when operating as a `Box<dyn Writer>`.
    jonasbb authored and folkertdev committed Jan 13, 2025
    Configuration menu
    Copy the full SHA
    3f3bb54 View commit details
    Browse the repository at this point in the history
  2. Add test that ensures the Drop implementation for BzEncoder will not …

    …regress
    
    Without the `impl<W: Write> Drop for BzEncoder<W>` the test fails with
    the error message:
        called `Result::unwrap()` on an `Err` value: Custom { kind: UnexpectedEof, error: "Input EOF reached before logical stream end" }
    jonasbb authored and folkertdev committed Jan 13, 2025
    Configuration menu
    Copy the full SHA
    c495204 View commit details
    Browse the repository at this point in the history
  3. link PR in the test

    als use a bit less memory; it's not really needed to prove the point
    folkertdev committed Jan 13, 2025
    Configuration menu
    Copy the full SHA
    81e2bb5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b4a143b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    09a87db View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2025

  1. Update rand requirement from 0.8 to 0.9

    Updates the requirements on [rand](https://github.com/rust-random/rand) to permit the latest version.
    - [Release notes](https://github.com/rust-random/rand/releases)
    - [Changelog](https://github.com/rust-random/rand/blob/master/CHANGELOG.md)
    - [Commits](rust-random/rand@0.8.0...0.9.0)
    
    ---
    updated-dependencies:
    - dependency-name: rand
      dependency-type: direct:production
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and bjorn3 committed Feb 10, 2025
    Configuration menu
    Copy the full SHA
    af06fd1 View commit details
    Browse the repository at this point in the history

Commits on Feb 11, 2025

  1. Disable bzip2-sys build script if rust backend is enabled (#125)

    * Disable bzip2-sys build script if rust backend is enabled
    
    Currently if one is to enable rust backend without disabling
    default features, the bzip2-sys build script would build the
    bzip2 again, making it meaningless to enable the feature.
    
    In many cases disabling default-features is hard (breaking
    backwards compatibility), so it'd be better to disable the
    bzip2-sys bulid-script, if the rust backend is enabled'
    
    It would still pull in cc-rs and pkg-config, but at least
    it won't compile the bzip2 c code again.'
    
    Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    
    * Disable bzip2-sys build script if rust backend is enabled
    
    Currently if one is to enable rust backend without disabling
    default features, the bzip2-sys build script would build the
    bzip2 again, making it meaningless to enable the feature.
    
    In many cases disabling default-features is hard (breaking
    backwards compatibility), so it'd be better to disable the
    bzip2-sys bulid-script, if the rust backend is enabled'
    
    It would still pull in cc-rs and pkg-config, but at least
    it won't compile the bzip2 c code again.'
    
    Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    
    * Disable bzip2-sys build script if rust backend is enabled
    
    Currently if one is to enable rust backend without disabling
    default features, the bzip2-sys build script would build the
    bzip2 again, making it meaningless to enable the feature.
    
    In many cases disabling default-features is hard (breaking
    backwards compatibility), so it'd be better to disable the
    bzip2-sys bulid-script, if the rust backend is enabled'
    
    It would still pull in cc-rs and pkg-config, but at least
    it won't compile the bzip2 c code again.'
    
    Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    
    ---------
    
    Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
    NobodyXu authored Feb 11, 2025
    Configuration menu
    Copy the full SHA
    6bd7c68 View commit details
    Browse the repository at this point in the history
  2. deprecate Compression::new

    folkertdev authored and bjorn3 committed Feb 11, 2025
    Configuration menu
    Copy the full SHA
    1818419 View commit details
    Browse the repository at this point in the history
  3. build the docs on CI

    Co-authored-by: bjorn3 <17426603+bjorn3@users.noreply.github.com>
    folkertdev and bjorn3 committed Feb 11, 2025
    Configuration menu
    Copy the full SHA
    55e3805 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dbbc3b4 View commit details
    Browse the repository at this point in the history
Loading