deref to delegate #409
Merged
deref to delegate #409
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous use of Deref/DerefMut was an anti-pattern. We now use the delegate crate to provide the same API. BREAKING CHANGE: code generic over the Deref behavior is now broken.
molpopgen
force-pushed
the
deref_to_delegate
branch
from
978d1e0 to
071d347
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace Deref/DerefMut for TableCollection and TreeSequence with delegates.
The use of Deref for these types is an anti-pattern.
The only API breakage is for code depending on the Deref behavior as a trait
or via
*.Such code probably doesn't exist.