Skip to content

Commit dfd1c7d

Browse files
committed
Working around the removal of the isSharded check in JsonPoweredCrudTestHelper
1 parent e31607a commit dfd1c7d

File tree

4 files changed

+9
-3
lines changed

4 files changed

+9
-3
lines changed

driver-async/src/test/functional/com/mongodb/async/client/CrudTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -35,6 +35,7 @@
3535
import java.util.List;
3636

3737
import static com.mongodb.ClusterFixture.getDefaultDatabaseName;
38+
import static com.mongodb.ClusterFixture.isSharded;
3839
import static com.mongodb.JsonTestServerVersionChecker.skipTest;
3940
import static com.mongodb.async.client.Fixture.getDefaultDatabase;
4041
import static com.mongodb.async.client.Fixture.getMongoClient;
@@ -68,6 +69,8 @@ public CrudTest(final String filename, final String description, final String da
6869
public void setUp() {
6970
super.setUp();
7071
assumeFalse(skipTest);
72+
// No runOn syntax for legacy CRUD, so skipping these manually for now
73+
assumeFalse(isSharded() && description.startsWith("Aggregate with $currentOp"));
7174
collection = Fixture.initializeCollection(new MongoNamespace(databaseName, getClass().getName()))
7275
.withDocumentClass(BsonDocument.class);
7376
helper = new JsonPoweredCrudTestHelper(description, getMongoClient().getDatabase(databaseName), collection);

driver-async/src/test/functional/com/mongodb/async/client/JsonPoweredCrudTestHelper.java

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -84,11 +84,9 @@
8484
import java.util.List;
8585
import java.util.concurrent.TimeUnit;
8686

87-
import static com.mongodb.async.client.Fixture.isSharded;
8887
import static com.mongodb.async.client.gridfs.helpers.AsyncStreamHelper.toAsyncInputStream;
8988
import static com.mongodb.async.client.gridfs.helpers.AsyncStreamHelper.toAsyncOutputStream;
9089
import static java.lang.String.format;
91-
import static org.junit.Assume.assumeTrue;
9290

9391
public class JsonPoweredCrudTestHelper {
9492
private final String description;
@@ -305,7 +303,6 @@ BsonDocument getAggregateResult(final BsonDocument collectionOptions, final Bson
305303

306304
BsonDocument getDatabaseAggregateResult(final BsonDocument collectionOptions, final BsonDocument arguments,
307305
@Nullable final ClientSession clientSession) {
308-
assumeTrue(!isSharded());
309306
List<BsonDocument> pipeline = new ArrayList<BsonDocument>();
310307
for (BsonValue stage : arguments.getArray("pipeline")) {
311308
pipeline.add(stage.asDocument());

driver-legacy/src/test/functional/com/mongodb/client/LegacyCrudTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,6 +33,7 @@
3333
import java.util.Collection;
3434
import java.util.List;
3535

36+
import static com.mongodb.ClusterFixture.isSharded;
3637
import static com.mongodb.JsonTestServerVersionChecker.skipTest;
3738
import static com.mongodb.client.Fixture.getDefaultDatabaseName;
3839
import static org.junit.Assert.assertEquals;
@@ -64,6 +65,8 @@ public LegacyCrudTest(final String filename, final String description, final Str
6465
public void setUp() {
6566
super.setUp();
6667
assumeFalse(skipTest);
68+
// No runOn syntax for legacy CRUD, so skipping these manually for now
69+
assumeFalse(isSharded() && description.startsWith("Aggregate with $currentOp"));
6770
if (!data.isEmpty()) {
6871
List<BsonDocument> documents = new ArrayList<BsonDocument>();
6972
for (BsonValue document : data) {

driver-sync/src/test/functional/com/mongodb/client/CrudTest.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,7 @@
3434
import java.util.List;
3535

3636
import static com.mongodb.ClusterFixture.getDefaultDatabaseName;
37+
import static com.mongodb.ClusterFixture.isSharded;
3738
import static com.mongodb.JsonTestServerVersionChecker.skipTest;
3839
import static org.junit.Assert.assertEquals;
3940
import static org.junit.Assume.assumeFalse;
@@ -64,6 +65,8 @@ public CrudTest(final String filename, final String description, final String da
6465
public void setUp() {
6566
super.setUp();
6667
assumeFalse(skipTest);
68+
// No runOn syntax for legacy CRUD, so skipping these manually for now
69+
assumeFalse(isSharded() && description.startsWith("Aggregate with $currentOp"));
6770
List<BsonDocument> documents = new ArrayList<BsonDocument>();
6871
if (!data.isEmpty()) {
6972
for (BsonValue document : data) {

0 commit comments

Comments
 (0)