-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Reduce jar size by using abstract classes #4751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Can you add to the PR how the uncompressed jar size changes after this please? Thanks for doing this. |
400ccdd to
3d4ac2e
Compare
|
I updated the description with sizes |
|
Biggest offenders remaining (can't fix because they are static methods and binary compatibility): |
Yet a substantial decrease in sizes is achieved, thank you! May I suggest the below representation of the size comparisons for nicer visualisation?
(generated from your data with help of Github Copilot) |
|
Hi @joroKr21 , thank you again for this incredible work! Meanwhile, would you mind updating your branch to the current state of the repository if you have time please? |
3d4ac2e to
b071721
Compare
b071721 to
18adcdc
Compare
4d54cd9 to
722be35
Compare
satorg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've looked through as thoroughly as I could and I have to say it is a tremendous and valuable work! Thank you for nailing it!
Traits generate bridge methods in every subclass
Co-authored-by: Sergey Torgashov <[email protected]>
722be35 to
3a2a230
Compare
|
@joroKr21 , thank you for keeping it up-to-date! I'm not sure if we should wait for the second approve, to be honest. |
Traits generate bridge methods in every subclass
See #4750