Merge pull request #60 from typesense/bugfix/soft_deleted

karakhanyans · web-flow · commit 4b76635713d4 · 2023-04-05T10:43:57.000+04:00
Bugfix Dont update Typesense document if the model is soft-deleted
diff --git a/src/Engines/TypesenseEngine.php b/src/Engines/TypesenseEngine.php
@@ -168,8 +168,10 @@ public function update($models): void
             $models->each->pushSoftDeleteMetadata();
         }
 
-        $this->typesense->importDocuments($collection, $models->map(fn($m) => $m->toSearchableArray())
-            ->toArray());
+        if (is_null($models->first()?->deleted_at)) {
+            $this->typesense->importDocuments($collection, $models->map(fn($m) => $m->toSearchableArray())
+                ->toArray());
+        }
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -168,8 +168,10 @@ public function update($models): void`
`168`	`168`	`$models->each->pushSoftDeleteMetadata();`
`169`	`169`	`}`
`170`	`170`
`171`		`- $this->typesense->importDocuments($collection, $models->map(fn($m) => $m->toSearchableArray())`
`172`		`- ->toArray());`
	`171`	`+ if (is_null($models->first()?->deleted_at)) {`
	`172`	`+ $this->typesense->importDocuments($collection, $models->map(fn($m) => $m->toSearchableArray())`
	`173`	`+ ->toArray());`
	`174`	`+ }`
`173`	`175`	`}`
`174`	`176`
`175`	`177`	`/**`