In SlidingUpPanelLayout.dispatchTouchEvent(), ignore horizontal scrolls #857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow child views with horizontally scrollable content to behave as expected, regardless of the state of the panel.
Author
|
@tokudu would you mind taking a look at this please? |
|
Vote +1 |
|
@tokudu I'd also recommend 👍 |
|
@tokudu + 1 vote |
Contributor
|
Merged |
Contributor
|
Will release new update on the weekend. |
Contributor
|
Thanks for the contribution |
Author
|
Thanks @tokudu |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow child views with horizontally scrollable content to behave as expected, regardless of the state of the panel.
My specific issue is this: I have a
RecyclerViewwhich has aLinearLayoutManagerwith a horizontal orientation. ThisRecyclerViewis one of many children inside aScrollView, and of course, thisScrollViewis set as the scrollable view in theSlidingUpPanelLayout.When the panel was in the
COLLAPSEDorANCHOREDstates, horizontal scrolls on thisRecyclerViewwere awkward. They felt sluggish, and often weren't handled properly.I would also expect this code change to fix the issue reported in #679.