Various (unconsequential) cleanup changes #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exception is Landscape.html, which remains invalid for having a script tag after the closing html tag.
The css was virtually identical for all example files. Some of them also had a transition rule, and two had a label class definition. These extra styles were also added to the base style, using classes to allow them to apply only when appropriate.
unconed
added a commit
that referenced
this pull request
Feb 18, 2014
Various (unconsequential) cleanup changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The biggest change here is moving the css to a separate file to avoid repeating it in all the example files.
This makes them simpler to inspect, apart from all the advantages of the DRY philosophy.
There are also whitespace tweaks, edits to allow validation, and a typo fix.