Small Application Refactoring (#244)

* refactoring application

* update test

* add Corporation to EntityType

Author: axshani

e2e_tests/application_test.py

@@ -56,7 +56,9 @@ def create_business_application():
                             Phone("1", "2025550158"), "[email protected]", ssn="574572795")
         ],
         year_of_incorporation=date.today() - timedelta(days=2 * 365),
-        business_vertical="Construction"
+        business_vertical="Construction",
+        tags={"test": "test"},
+        idempotency_key=generate_uuid()
     )
 
     return client.applications.create(request)

unit/models/__init__.py

@@ -21,8 +21,10 @@
 SourceOfIncome = Literal["EmploymentOrPayrollIncome", "PartTimeOrContractorIncome", "InheritancesAndGifts",
                          "PersonalInvestments", "BusinessOwnershipInterests", "GovernmentBenefits"]
 Status = Literal["Approved", "Denied", "PendingReview"]
-Title = Literal["CEO", "COO", "CFO", "President"]
-EntityType = Literal["Corporation", "LLC", "Partnership"]
+Title = Literal["CEO", "COO", "CFO", "President", "BenefitsAdministrationOfficer", "CIO", "VP", "AVP", "Treasurer",
+                "Secretary", "Controller", "Manager", "Partner", "Member"]
+EntityType = Literal["Corporation", "LLC", "Partnership", "PubliclyTradedCorporation", "PrivatelyHeldCorporation",
+                     "NotForProfitOrganization"]
 UseSelfieVerification = Literal["Never", "ReplaceIdentification"]
 
 

unit/models/application.py

@@ -187,7 +187,8 @@ def __init__(self, name: str, address: Address, phone: Phone, state_of_incorpora
                  year_of_incorporation: Optional[Union[date, str]] = None,
                  countries_of_operation: Optional[List[str]] = None, stock_symbol: Optional[str] = None,
                  business_vertical: Optional[BusinessVertical] = None,
-                 device_fingerprints: Optional[List[DeviceFingerprint]] = None
+                 device_fingerprints: Optional[List[DeviceFingerprint]] = None,
+                 tags: Optional[Dict[str, str]] = None, idempotency_key: Optional[str] = None
                  ):
         self.name = name
         self.address = address
@@ -210,6 +211,8 @@ def __init__(self, name: str, address: Address, phone: Phone, state_of_incorpora
         self.stock_symbol = stock_symbol
         self.business_vertical = business_vertical
         self.device_fingerprints = device_fingerprints
+        self.tags = tags
+        self.idempotency_key = idempotency_key
 
     def to_json_api(self) -> Dict:
         return super().to_payload("businessApplication")