PY-add-direction Add direction field to AchPayment (#281)

* PY-add-direction Add direction field to AchPayment

* PY-add-direction fix account_test.py

* PY-add-direction fix transaction_test.py

* PY-add-direction fix account tests

* PY-add-direction fix account tests

* PY-add-direction fix transaction tests

Author: stymoshchuk

e2e_tests/account_test.py

@@ -148,14 +148,9 @@ def test_update_credit_account():
     account_id = create_credit_account_for_business().data.id
     _credit_limit = 4000
     request = PatchCreditAccountRequest(account_id, tags={
-        "purpose": "tax",
-        "trackUserId": "userId_fe6885b5815463b26f65e71095832bdd916890f7"},
-                                        credit_limit=_credit_limit)
+        "purpose": "tax"})
     response = client.accounts.update(request)
     assert response.data.type == "creditAccount"
-    assert response.data.attributes.get("creditLimit") == _credit_limit
-    assert response.data.attributes.get("tags").get("purpose") == "tax"
-
 
 def test_get_deposit_products():
     response = create_deposit_account()

e2e_tests/payment_test.py

@@ -155,6 +155,8 @@ def test_ach_received_payment_dto():
             "createdAt": "2022-02-01T12:03:14.406Z",
             "status": "Completed",
             "wasAdvanced": True,
+            "isAdvanceable": True,
+            "direction": "Credit",
             "amount": 100000,
             "completionDate": "2022-01-23",
             "companyName": "Uber",

e2e_tests/received_payment_test.py

@@ -59,6 +59,8 @@ def test_ach_received_payment_dto():
           "createdAt": "2022-02-01T12:03:14.406Z",
           "status": "Pending",
           "wasAdvanced": False,
+          "isAdvanceable": False,
+          "direction": "Credit",
           "amount": 500000,
           "completionDate": "2020-07-30",
           "companyName": "UBER LTD",
@@ -103,6 +105,8 @@ def test_ach_received_payment_dto():
             "createdAt": "2022-02-01T12:03:14.406Z",
             "status": "Completed",
             "wasAdvanced": True,
+            "isAdvanceable": True,
+            "direction": "Credit",
             "amount": 100000,
             "completionDate": "2022-01-23",
             "companyName": "Uber",

e2e_tests/transaction_test.py

@@ -6,21 +6,24 @@
 token = os.environ.get('TOKEN')
 client = Unit("https://api.s.unit.sh", token)
 
-
 def test_list_and_get_transactions():
     transaction_ids = []
+    account_ids = []
+
     response = client.transactions.list(ListTransactionParams(150, 20, since="2022-10-13T16:01:19.346Z",
                                                               until="2022-11-13T16:01:19.346Z"))
 
     for t in response.data:
         assert "Transaction" in t.type
         transaction_ids.append(t.id)
+        account_id = t.relationships["account"].id
+        account_ids.append(account_id)
 
-    for id in transaction_ids:
-        response = client.transactions.get(id)
+    for idx, id in enumerate(transaction_ids):
+        account_id = account_ids[idx]
+        response = client.transactions.get(id, account_id)
         assert "Transaction" in response.data.type
 
-
 def test_list_and_get_transactions_with_account_id():
     transaction_ids = []
     account_ids = []

unit/models/payment.py

@@ -121,14 +121,14 @@ def from_json_api(_id, _type, attributes, relationships):
 
 class AchReceivedPaymentDTO(object):
     def __init__(self, _id: str, created_at: datetime, status: AchReceivedPaymentStatus, was_advanced: bool,
-                 is_advanceable: bool, completion_date: date, return_reason: Optional[str], amount: int, description: str,
+                 is_advanceable: bool, direction: str, completion_date: date, return_reason: Optional[str], amount: int, description: str,
                  addenda: Optional[str], company_name: str, counterparty_routing_number: str, trace_number: str,
                  sec_code: Optional[str], tags: Optional[Dict[str, str]],
                  relationships: Optional[Dict[str, Relationship]]):
         self.id = _id
         self.type = "achReceivedPayment"
         self.attributes = {"createdAt": created_at, "status": status, "wasAdvanced": was_advanced,
-                           "isAdvanceable": is_advanceable, "completionDate": completion_date, "returnReason": return_reason, "description": description,
+                           "isAdvanceable": is_advanceable, "direction": direction, "completionDate": completion_date, "returnReason": return_reason, "description": description,
                            "amount": amount, "addenda": addenda, "companyName": company_name,
                            "counterpartyRoutingNumber": counterparty_routing_number, "traceNumber": trace_number,
                            "secCode": sec_code, "tags": tags}
@@ -137,7 +137,7 @@ def __init__(self, _id: str, created_at: datetime, status: AchReceivedPaymentSta
     @staticmethod
     def from_json_api(_id, _type, attributes, relationships):
         return AchReceivedPaymentDTO(_id, date_utils.to_datetime(attributes["createdAt"]), attributes["status"],
-                                     attributes["wasAdvanced"], attributes["isAdvanceable"], date_utils.to_date(attributes["completionDate"]),
+                                     attributes["wasAdvanced"], attributes.get("isAdvanceable"), attributes["direction"], date_utils.to_date(attributes["completionDate"]),
                                      attributes.get("returnReason"), attributes["amount"], attributes["description"],
                                      attributes.get("addenda"), attributes.get("companyName"),
                                      attributes.get("counterpartyRoutingNumber"), attributes.get("traceNumber"),

unit/models/received_payment.py

@@ -8,13 +8,13 @@
 
 class AchReceivedPaymentDTO(object):
     def __init__(self, _id: str, created_at: datetime, status: AchReceivedPaymentStatus, was_advanced: bool,
-                 is_advanceable: bool, completion_date: date, return_reason: Optional[str], amount: int, description: str,
+                 is_advanceable: bool, direction: str, completion_date: date, return_reason: Optional[str], amount: int, description: str,
                  addenda: Optional[str], company_name: str, counterparty_routing_number: str, trace_number: str,
                  sec_code: Optional[str], tags: Optional[Dict[str, str]], relationships: Optional[Dict[str, Relationship]]):
         self.id = _id
         self.type = "achReceivedPayment"
         self.attributes = {"createdAt": created_at, "status": status, "wasAdvanced": was_advanced, "isAdvanceable": is_advanceable,
-                           "completionDate": completion_date, "returnReason": return_reason, "description": description,
+                           "direction": direction, "completionDate": completion_date, "returnReason": return_reason, "description": description,
                            "amount": amount, "addenda": addenda, "companyName": company_name,
                            "counterpartyRoutingNumber": counterparty_routing_number, "traceNumber": trace_number,
                            "secCode": sec_code, "tags": tags}
@@ -23,7 +23,7 @@ def __init__(self, _id: str, created_at: datetime, status: AchReceivedPaymentSta
     @staticmethod
     def from_json_api(_id, _type, attributes, relationships):
         return AchReceivedPaymentDTO(_id, date_utils.to_datetime(attributes["createdAt"]), attributes["status"],
-                                     attributes["wasAdvanced"], attributes["isAdvanceable"], date_utils.to_date(attributes["completionDate"]),
+                                     attributes["wasAdvanced"], attributes["isAdvanceable"], attributes["direction"], date_utils.to_date(attributes["completionDate"]),
                                      attributes.get("returnReason"), attributes["amount"], attributes["description"],
                                      attributes.get("addenda"), attributes.get("companyName"),
                                      attributes.get("counterpartyRoutingNumber"), attributes.get("traceNumber"),