Skip to content

verifychecksums.bin fails to build with PGv11 #70

@mbanck

Description

@mbanck

TRUE and FALSE (all-caps) apparently no longer exist:

postgres-toolkit/src/verifychecksum$ LANG=C make
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Wendif-labels -Wmissing-format-attribute -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -g -g -O2 -fstack-protector-strong -Wformat -Werror=format-security -fno-omit-frame-pointer -I. -I./ -I/usr/include/postgresql/11/server -I/usr/include/postgresql/internal  -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -I/usr/include/libxml2  -I/usr/include/mit-krb5  -c -o verifychecksum.o verifychecksum.c
verifychecksum.c: In function 'verify_page':
verifychecksum.c:52:14: error: 'FALSE' undeclared (first use in this function)
       return FALSE;
              ^~~~~
verifychecksum.c:52:14: note: each undeclared identifier is reported only once for each function it appears in
verifychecksum.c:55:10: error: 'TRUE' undeclared (first use in this function)
   return TRUE;
          ^~~~
verifychecksum.c: In function 'verify_segmentfile':
verifychecksum.c:96:14: error: 'FALSE' undeclared (first use in this function)
       return FALSE;
              ^~~~~
verifychecksum.c:102:10: error: 'TRUE' undeclared (first use in this function)
   return TRUE;
          ^~~~
verifychecksum.c: In function 'verify_page':
verifychecksum.c:56:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
verifychecksum.c: In function 'verify_segmentfile':
verifychecksum.c:103:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
<builtin>: recipe for target 'verifychecksum.o' failed
make: *** [verifychecksum.o] Error 1

Changing them to true and false makes the build go fine.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions