Cleanup of the new horizontal bar functionality.

 - added class prefix to the bar class, to minimize the chance for namespace collisions
 - exposed and documented the MBBarProgressView interface
 - removed some non-crucial methods to simplify the API
 - adjusted the default values for some attributers
 - cleaned up the code style, so it matches the rest of the class
 - added proper ARC macros
 - using KVO instead of accessor overrides for UI update triggering

Author: matej

MBProgressHUD.h

@@ -451,3 +451,34 @@ typedef void (^MBProgressHUDCompletionBlock)();
 @property (nonatomic, assign, getter = isAnnular) BOOL annular;
 
 @end
+
+
+/**
+ * A flat bar progress view. 
+ */
+@interface MBBarProgressView : UIView
+
+/**
+ * Progress (0.0 to 1.0)
+ */
+@property (nonatomic, assign) float progress;
+
+/**
+ * Bar border line color.
+ * Defaults to white [UIColor whiteColor].
+ */
+@property (nonatomic, MB_STRONG) UIColor *lineColor;
+
+/**
+ * Bar background color.
+ * Defaults to clear [UIColor clearColor];
+ */
+@property (nonatomic, MB_STRONG) UIColor *progressRemainingColor;
+
+/**
+ * Bar progress color.
+ * Defaults to white [UIColor whiteColor].
+ */
+@property (nonatomic, MB_STRONG) UIColor *progressColor;
+
+@end

MBProgressHUD.m

@@ -28,18 +28,6 @@
 static const CGFloat kLabelFontSize = 16.f;
 static const CGFloat kDetailsLabelFontSize = 12.f;
 
-@interface FlatProgressView : UIView
-
-@property (nonatomic, readwrite) float minValue;
-@property (nonatomic, readwrite) float maxValue;
-@property (nonatomic, readwrite) float progress;
-@property (nonatomic, strong) UIColor *lineColor;
-@property (nonatomic, strong) UIColor *progressRemainingColor;
-@property (nonatomic, strong) UIColor *progressColor;
-
--(void)setNewRect:(CGRect)newFrame;
-
-@end
 
 @interface MBProgressHUD ()
 
@@ -479,12 +467,9 @@ - (void)updateIndicators {
 		[self addSubview:indicator];
 	}
 	else if (mode == MBProgressHUDModeDeterminateHorizontalBar) {
+		// Update to bar determinate indicator
 		[indicator removeFromSuperview];
-		FlatProgressView* flatProgressView = [[FlatProgressView alloc] initWithFrame:CGRectMake(0.0f, 0.0f, 120.0f, 20.0f)];
-		flatProgressView.progressColor = [UIColor whiteColor];
-		flatProgressView.progressRemainingColor = [UIColor clearColor];
-		flatProgressView.lineColor = [UIColor whiteColor];
-        self.indicator = MB_AUTORELEASE(flatProgressView);
+        self.indicator = MB_AUTORELEASE([[MBBarProgressView alloc] init]);
 		[self addSubview:indicator];
 	}
 	else if (mode == MBProgressHUDModeDeterminate || mode == MBProgressHUDModeAnnularDeterminate) {
@@ -885,39 +870,39 @@ - (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(N
 
 @end
 
-@implementation FlatProgressView
 
-- (id)initWithFrame:(CGRect)frame
-{
+@implementation MBBarProgressView
+
+- (id)init {
+	return [self initWithFrame:CGRectMake(.0f, .0f, 120.0f, 20.0f)];
+}
+
+- (id)initWithFrame:(CGRect)frame {
     self = [super initWithFrame:frame];
-    if (self)
-	{
-		_minValue = 0;
-		_maxValue = 1;
-		_progress = 0;
-		self.backgroundColor = [UIColor clearColor];
+    if (self) {
+		_progress = 0.f;
 		_lineColor = [UIColor whiteColor];
-		_progressColor = [UIColor darkGrayColor];
-		_progressRemainingColor = [UIColor lightGrayColor];
+		_progressColor = [UIColor whiteColor];
+		_progressRemainingColor = [UIColor clearColor];
+		self.backgroundColor = [UIColor clearColor];
+		self.opaque = NO;
+		[self registerForKVO];
     }
     return self;
 }
 
-- (void)dealloc
-{
-	
+
+- (void)dealloc {
+	[self unregisterFromKVO];
 #if !__has_feature(objc_arc)
-	
 	[_lineColor release];
 	[_progressColor release];
 	[_progressRemainingColor release];
-	[super dealloc];	
+	[super dealloc];
 #endif
-	
 }
 
-- (void)drawRect:(CGRect)rect
-{
+- (void)drawRect:(CGRect)rect {
 	CGContextRef context = UIGraphicsGetCurrentContext();
 
 	// setup properties
@@ -949,11 +934,10 @@ - (void)drawRect:(CGRect)rect
 	// setup to draw progress color
 	CGContextSetFillColorWithColor(context, [_progressColor CGColor]);
 	radius = radius - 2;
-	float amount = (self.progress/(self.maxValue - self.minValue)) * (rect.size.width);
+	float amount = self.progress * rect.size.width;
 
 	// if progress is in the middle area
-	if (amount >= radius + 4 && amount <= (rect.size.width - radius - 4))
-	{
+	if (amount >= radius + 4 && amount <= (rect.size.width - radius - 4)) {
 		// top
 		CGContextMoveToPoint(context, 4, rect.size.height/2);
 		CGContextAddArcToPoint(context, 4, 4, radius + 4, 4, radius);
@@ -970,8 +954,7 @@ - (void)drawRect:(CGRect)rect
 	}
 
 	// progress is in the right arc
-	else if (amount > radius + 4)
-	{
+	else if (amount > radius + 4) {
 		float x = amount - (rect.size.width - radius - 4);
 
 		// top
@@ -996,8 +979,7 @@ - (void)drawRect:(CGRect)rect
 	}
 
 	// progress is in the left arc
-	else if (amount < radius + 4 && amount > 0)
-	{
+	else if (amount < radius + 4 && amount > 0) {
 		// top
 		CGContextMoveToPoint(context, 4, rect.size.height/2);
 		CGContextAddArcToPoint(context, 4, 4, radius + 4, 4, radius);
@@ -1012,65 +994,25 @@ - (void)drawRect:(CGRect)rect
 	}
 }
 
--(void)setNewRect:(CGRect)newFrame
-{
-	self.frame = newFrame;
-	[self setNeedsDisplay];
-}
-
--(void)setMinValue:(float)newMin
-{
-	_minValue = newMin;
-	[self setNeedsDisplay];
-}
-
--(void)setMaxValue:(float)newMax
-{
-	_maxValue = newMax;
-	[self setNeedsDisplay];
-}
+#pragma mark - KVO
 
--(void)setProgress:(float)newValue
-{
-	_progress = newValue;
-	[self setNeedsDisplay];
+- (void)registerForKVO {
+	for (NSString *keyPath in [self observableKeypaths]) {
+		[self addObserver:self forKeyPath:keyPath options:NSKeyValueObservingOptionNew context:NULL];
+	}
 }
 
--(void)setLineColor:(UIColor *)newColor
-{
-	
-#if !__has_feature(objc_arc)
-	
-	[_lineColor release];
-	
-#endif
-	
-	_lineColor = newColor;
-	[self setNeedsDisplay];
+- (void)unregisterFromKVO {
+	for (NSString *keyPath in [self observableKeypaths]) {
+		[self removeObserver:self forKeyPath:keyPath];
+	}
 }
 
--(void)setProgressColor:(UIColor *)newColor
-{
-#if !__has_feature(objc_arc)
-	
-	[_progressColor release];
-	
-#endif
-	
-	_progressColor = newColor;
-	[self setNeedsDisplay];
+- (NSArray *)observableKeypaths {
+	return [NSArray arrayWithObjects:@"lineColor", @"progressRemainingColor", @"progressColor", @"progress", nil];
 }
 
--(void)setProgressRemainingColor:(UIColor *)newColor
-{
-	
-#if !__has_feature(objc_arc)
-	
-	[_progressRemainingColor release];
-	
-#endif
-	
-	_progressRemainingColor = newColor;
+- (void)observeValueForKeyPath:(NSString *)keyPath ofObject:(id)object change:(NSDictionary *)change context:(void *)context {
 	[self setNeedsDisplay];
 }