Use strict types everywhere

Author: valga

src/Common/PublishAckPacket.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Fbns\Client\Common;
 
 use BinSoul\Net\Mqtt\Packet\PublishAckPacket as BasePublishAckPacket;

src/Json.php

@@ -1,17 +1,17 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Fbns\Client;
 
 class Json
 {
     /**
      * Special decoder to keep big numbers on x86 PHP builds.
      *
-     * @param string $json
-     *
      * @return mixed
      */
-    public static function decode($json)
+    public static function decode(string $json)
     {
         $flags = 0;
         if (PHP_INT_SIZE === 4) {

src/Lite/ConnectRequestPacket.php

@@ -1,12 +1,6 @@
 <?php
 
-/*
- * This file is part of net-mqtt.
- *
- * Copyright (c) 2015 Sebastian Mößler [email protected]
- *
- * This source file is subject to the MIT license.
- */
+declare(strict_types=1);
 
 namespace Fbns\Client\Lite;
 
@@ -66,22 +60,16 @@ public function write(PacketStream $stream): void
 
     /**
      * Returns the protocol level.
-     *
-     * @return int
      */
-    public function getProtocolLevel()
+    public function getProtocolLevel(): int
     {
         return $this->protocolLevel;
     }
 
     /**
      * Sets the protocol level.
-     *
-     * @param int $value
-     *
-     * @throws \InvalidArgumentException
      */
-    public function setProtocolLevel($value)
+    public function setProtocolLevel(int $value): void
     {
         if ($value != 3) {
             throw new \InvalidArgumentException(sprintf('Unknown protocol level %d.', $value));
@@ -92,42 +80,32 @@ public function setProtocolLevel($value)
 
     /**
      * Returns the payload.
-     *
-     * @return string
      */
-    public function getPayload()
+    public function getPayload(): string
     {
         return $this->payload;
     }
 
     /**
      * Sets the payload.
-     *
-     * @param string $value
      */
-    public function setPayload($value)
+    public function setPayload(string $value)
     {
         $this->payload = $value;
     }
 
     /**
      * Returns the flags.
-     *
-     * @return int
      */
-    public function getFlags()
+    public function getFlags(): int
     {
         return $this->flags;
     }
 
     /**
      * Sets the flags.
-     *
-     * @param int $value
-     *
-     * @throws \InvalidArgumentException
      */
-    public function setFlags($value)
+    public function setFlags(int $value)
     {
         if ($value > 255) {
             throw new \InvalidArgumentException(sprintf('Expected a flags lower than 255 but got %d.', $value));
@@ -138,22 +116,16 @@ public function setFlags($value)
 
     /**
      * Returns the keep alive time in seconds.
-     *
-     * @return int
      */
-    public function getKeepAlive()
+    public function getKeepAlive(): int
     {
         return $this->keepAlive;
     }
 
     /**
      * Sets the keep alive time in seconds.
-     *
-     * @param int $value
-     *
-     * @throws \InvalidArgumentException
      */
-    public function setKeepAlive($value)
+    public function setKeepAlive(int $value): void
     {
         if ($value > 65535) {
             throw new \InvalidArgumentException(sprintf('Expected a keep alive time lower than 65535 but got %d.', $value));
@@ -164,22 +136,16 @@ public function setKeepAlive($value)
 
     /**
      * Returns the protocol name.
-     *
-     * @return string
      */
-    public function getProtocolName()
+    public function getProtocolName(): string
     {
         return $this->protocolName;
     }
 
     /**
      * Sets the protocol name.
-     *
-     * @param string $value
-     *
-     * @throws \InvalidArgumentException
      */
-    public function setProtocolName($value)
+    public function setProtocolName(string $value): void
     {
         $this->assertValidStringLength($value, false);
 

src/Lite/ConnectResponsePacket.php

@@ -1,22 +1,13 @@
 <?php
 
-/*
- * This file is part of net-mqtt.
- *
- * Copyright (c) 2015 Sebastian Mößler [email protected]
- *
- * This source file is subject to the MIT license.
- */
+declare(strict_types=1);
 
 namespace Fbns\Client\Lite;
 
 use BinSoul\Net\Mqtt\Packet;
 use BinSoul\Net\Mqtt\Packet\BasePacket;
 use BinSoul\Net\Mqtt\PacketStream;
 
-/**
- * Represents the CONNACK packet.
- */
 class ConnectResponsePacket extends BasePacket
 {
     /** @var string[][] */
@@ -81,7 +72,7 @@ public function write(PacketStream $stream): void
         $data->writeByte($this->flags);
         $data->writeByte($this->returnCode);
 
-        if ($this->auth !== null && strlen($this->auth)) {
+        if ($this->auth !== null && $this->auth !== '') {
             $data->writeString($this->auth);
         }
 
@@ -93,40 +84,32 @@ public function write(PacketStream $stream): void
 
     /**
      * Returns the return code.
-     *
-     * @return int
      */
-    public function getReturnCode()
+    public function getReturnCode(): int
     {
         return $this->returnCode;
     }
 
     /**
      * Indicates if the connection was successful.
-     *
-     * @return bool
      */
-    public function isSuccess()
+    public function isSuccess(): bool
     {
         return $this->returnCode === 0;
     }
 
     /**
      * Indicates if the connection failed.
-     *
-     * @return bool
      */
-    public function isError()
+    public function isError(): bool
     {
         return $this->returnCode > 0;
     }
 
     /**
      * Returns a string representation of the returned error code.
-     *
-     * @return int
      */
-    public function getErrorName()
+    public function getErrorName(): string
     {
         if (isset(self::$returnCodes[$this->returnCode])) {
             return self::$returnCodes[$this->returnCode][0];
@@ -135,10 +118,7 @@ public function getErrorName()
         return 'Error '.$this->returnCode;
     }
 
-    /**
-     * @return string
-     */
-    public function getAuth()
+    public function getAuth(): string
     {
         return $this->auth;
     }

src/Lite/FlowFactory.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Fbns\Client\Lite;
 
 use BinSoul\Net\Mqtt\ClientIdentifierGenerator;

src/Lite/OutgoingConnectFlow.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Fbns\Client\Lite;
 
 use BinSoul\Net\Mqtt\ClientIdentifierGenerator;
@@ -8,9 +10,6 @@
 use BinSoul\Net\Mqtt\Packet;
 use BinSoul\Net\Mqtt\PacketFactory;
 
-/**
- * Represents a flow starting with an outgoing CONNECT packet.
- */
 class OutgoingConnectFlow extends BaseOutgoingConnectFlow
 {
     const PROTOCOL_LEVEL = 3;

src/Lite/PacketFactory.php

@@ -1,22 +1,16 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Fbns\Client\Lite;
 
 use BinSoul\Net\Mqtt\Exception\UnknownPacketTypeException;
 use BinSoul\Net\Mqtt\Packet;
 use BinSoul\Net\Mqtt\PacketFactory as PacketFactoryInterface;
 use Fbns\Client\Common\PublishAckPacket;
 
-/**
- * Builds instances of the {@see Packet} interface.
- */
 class PacketFactory implements PacketFactoryInterface
 {
-    /**
-     * Map of packet types to packet classes.
-     *
-     * @var string[]
-     */
     private static $mapping = [
         Packet::TYPE_CONNECT => ConnectRequestPacket::class,
         Packet::TYPE_CONNACK => ConnectResponsePacket::class,

src/Mqtt/FbnsConnection.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Fbns\Client\Mqtt;
 
 use BinSoul\Net\Mqtt\Message;

src/Network.php

@@ -1,5 +1,7 @@
 <?php
 
+declare(strict_types=1);
+
 namespace Fbns\Client;
 
 use Fbns\Client\Network\NetworkSubtype;