Rename attachment to NoWarn

Simple rename to `NoWarnAttachment`.

It is still used selectively to turn off unused
warning for pattern variables.

Author: som-snytt

src/compiler/scala/tools/nsc/ast/parser/Parsers.scala

@@ -1969,7 +1969,7 @@ self =>
           atPos(p.pos.start, p.pos.start, body.pos.end) {
             val t = Bind(name, body)
             body match {
-              case Ident(nme.WILDCARD) if settings.warnUnusedPatVars => t updateAttachment AtBoundIdentifierAttachment
+              case Ident(nme.WILDCARD) if settings.warnUnusedPatVars => t updateAttachment NoWarnAttachment
               case _ => t
             }
           }

src/compiler/scala/tools/nsc/typechecker/TypeDiagnostics.scala

@@ -80,7 +80,7 @@ trait TypeDiagnostics {
   }
 
   // Bind of pattern var was `x @ _`
-  private def atBounded(t: Tree) = t.hasAttachment[AtBoundIdentifierAttachment.type]
+  private def atBounded(t: Tree) = t.hasAttachment[NoWarnAttachment.type]
 
   // ValDef was a PatVarDef `val P(x) = ???`
   private def wasPatVarDef(t: Tree) = t.hasAttachment[PatVarDefAttachment.type]

src/reflect/scala/reflect/internal/StdAttachments.scala

@@ -64,12 +64,12 @@ trait StdAttachments {
   case object BackquotedIdentifierAttachment extends PlainAttachment
 
   /** A pattern binding exempt from unused warning.
-    *
-    * Its host `Ident` has been created from a pattern2 binding, `case x @ p`.
-    * In the absence of named parameters in patterns, allows nuanced warnings for unused variables.
-    * Hence, `case X(x = _) =>` would not warn; for now, `case X(x @ _) =>` is documentary if x is unused.
-    */
-  case object AtBoundIdentifierAttachment extends PlainAttachment
+   *
+   *  Its host `Ident` has been created from a pattern2 binding, `case x @ p`.
+   *  In the absence of named parameters in patterns, allows nuanced warnings for unused variables.
+   *  Hence, `case X(x = _) =>` would not warn; for now, `case X(x @ _) =>` is documentary if x is unused.
+   */
+  case object NoWarnAttachment extends PlainAttachment
 
   /** Indicates that a `ValDef` was synthesized from a pattern definition, `val P(x)`.
    */

src/reflect/scala/reflect/internal/TreeGen.scala

@@ -732,19 +732,19 @@ abstract class TreeGen {
   def mkPatDef(pat: Tree, rhs: Tree)(implicit fresh: FreshNameCreator): List[ValDef] =
     mkPatDef(Modifiers(0), pat, rhs)
 
-  private def propagateAtBoundAttachment(from: Tree, to: ValDef): to.type =
-    if (isPatVarWarnable && from.hasAttachment[AtBoundIdentifierAttachment.type]) to.updateAttachment(AtBoundIdentifierAttachment)
+  private def propagateNoWarnAttachment(from: Tree, to: ValDef): to.type =
+    if (isPatVarWarnable && from.hasAttachment[NoWarnAttachment.type]) to.updateAttachment(NoWarnAttachment)
     else to
 
   // Keep marker for `x@_`, add marker for `val C(x) = ???` to distinguish from ordinary `val x = ???`.
   private def propagatePatVarDefAttachments(from: Tree, to: ValDef): to.type =
-    propagateAtBoundAttachment(from, to).updateAttachment(PatVarDefAttachment)
+    propagateNoWarnAttachment(from, to).updateAttachment(PatVarDefAttachment)
 
   /** Create tree for pattern definition <mods val pat0 = rhs> */
   def mkPatDef(mods: Modifiers, pat: Tree, rhs: Tree)(implicit fresh: FreshNameCreator): List[ValDef] = matchVarPattern(pat) match {
     case Some((name, tpt)) =>
       List(atPos(pat.pos union rhs.pos) {
-        propagateAtBoundAttachment(pat, ValDef(mods, name.toTermName, tpt, rhs))
+        propagateNoWarnAttachment(pat, ValDef(mods, name.toTermName, tpt, rhs))
       })
 
     case None =>
@@ -815,7 +815,7 @@ abstract class TreeGen {
 
   private def unwarnable(pat: Tree): Tree = {
     pat foreach {
-      case b @ Bind(_, _) => b updateAttachment AtBoundIdentifierAttachment
+      case b @ Bind(_, _) => b updateAttachment NoWarnAttachment
       case _ =>
     }
     pat
@@ -917,7 +917,7 @@ abstract class TreeGen {
       case Ident(name) if treeInfo.isVarPattern(tree) && name != nme.WILDCARD =>
         atPos(tree.pos) {
           val b = Bind(name, atPos(tree.pos.focus) (Ident(nme.WILDCARD)))
-          if (forFor && isPatVarWarnable) b updateAttachment AtBoundIdentifierAttachment
+          if (forFor && isPatVarWarnable) b updateAttachment NoWarnAttachment
           else b
         }
       case Typed(id @ Ident(name), tpt) if treeInfo.isVarPattern(id) && name != nme.WILDCARD =>

src/reflect/scala/reflect/runtime/JavaUniverseForce.scala

@@ -40,7 +40,7 @@ trait JavaUniverseForce { self: runtime.JavaUniverse  =>
     this.SAMFunction
     this.DelambdafyTarget
     this.BackquotedIdentifierAttachment
-    this.AtBoundIdentifierAttachment
+    this.NoWarnAttachment
     this.PatVarDefAttachment
     this.ForAttachment
     this.SyntheticUnitAttachment