Add boson ngx007 support #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for the Boson NGX007 configuration by introducing new device tree source files, updating kernel and bootloader recipes, and adjusting machine configuration. Key changes include:
- New device tree files for the Boson NGX007 board (e.g. tegra234-orin-nx-cti-NGX007.dts)
- Updates to kernel and bootloader recipe append files to accommodate additional hardware files and copy steps
- Revised machine configuration files to point to the new device tree and pinmux settings
Reviewed Changes
Copilot reviewed 26 out of 26 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| recipes-kernel/nvidia-kernel-oot/nvidia-kernel-oot_git.bbappend | Adds a preconfigure task for copying hardware files |
| recipes-kernel/nvidia-kernel-oot/files/hardware/nvidia/t23x/nv-public/tegra234-p3768-0000.dtsi | New hardware DTS file introduced |
| recipes-kernel/nvidia-kernel-oot/files/hardware/nvidia/t23x/cti-public/orin-nx-nano/orin-nx/tegra234-orin-nx-cti-NGX007.dts | New device tree file for Boson NGX007 board |
| recipes-kernel/nvidia-kernel-oot/files/hardware/nvidia/t23x/cti-public/orin-nx-nano/cti_overlay/tegra234-orin-nx-cti-overlay.dts | Overlay DTS with updated overlay name |
| recipes-kernel/linux/linux-yocto_6.12.bbappend and related files | Minor changes to support additional hardware configuration (igb.cfg) |
| recipes-bsp/tegra-binaries/* | Updates in bootloader recipes to support the new board configuration |
| conf/machine/* | Machine configuration files updated to reference the new NGX007 device tree and pinmux settings |
Comments suppressed due to low confidence (2)
recipes-kernel/nvidia-kernel-oot/files/hardware/nvidia/t23x/cti-public/orin-nx-nano/tegra234-orin-nx-cti-NGX007.dts:29
- [nitpick] The node name 'forcerecovery' is inconsistent with the naming convention observed elsewhere (e.g., 'key-force-recovery'); consider aligning the names for clarity.
forcerecovery {
recipes-kernel/nvidia-kernel-oot/files/hardware/nvidia/t23x/cti-public/orin-nx-nano/cti_overlay/tegra234-orin-nx-cti-overlay.dts:8
- [nitpick] The overlay name appears to reference older board nomenclature; consider updating it to reflect the Boson NGX007 support for consistency.
overlay-name = "Tegra234 p3768-0000+p3767-xxxx Dynamic Overlay";
| }; | ||
|
|
||
|
|
||
| hdr40_vdd_3v3: p3768_vdd_3v3_sys: regulator@101 { |
There was a problem hiding this comment.
Duplicate definition of regulator node 'hdr40_vdd_3v3' detected; consider removing one of the duplicate blocks to avoid conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.