Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: vercel/next.js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v14.2.8
Choose a base ref
...
head repository: vercel/next.js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v14.2.9
Choose a head ref
  • 11 commits
  • 57 files changed
  • 5 contributors

Commits on Sep 6, 2024

  1. Revert "Fix esm property def in flight loader (#66990)" (#69749)

    This reverts commit 9bb06c5.
    
    This was a sort breaking change that could effect using `next/dynamic`
    in server component, when the imported one is client component. Ideally
    you shouldn't directly return it due to the property access restriction
    for client reference. We've already provided related codemod for v15 but
    this might be a bit surprise for users upgrading to the new patch.
    
    Reverted as it's not necessarily part of ESM externals fixes.
    
    Fixes #69720
    huozhi authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    a882e6e View commit details
    Browse the repository at this point in the history
  2. test: both wrapped and unwrapped dynamic() (#69780)

    We should be testing both usage patterns, i.e. returning a component
    wrapped in a `{ default: ... }` and just a bare component.
    
    Note that the behavior here will partially change in 15, so this test is
    just so that we can avoid regressing in 14.x.
    lubieowoce authored Sep 6, 2024
    Configuration menu
    Copy the full SHA
    86547db View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    bf48448 View commit details
    Browse the repository at this point in the history
  4. Fix middleware fallback: false case (#69799)

    This ensures we properly set the request meta during our middleware
    invoke so that the `NoFallbackError` bubbling is handled properly.
    Without these fields set we bubble the error unexpectedly causing an
    unexpected 500 instead of a 404.
    
    x-ref: #66987
    Closes: #69428
    ijjk committed Sep 6, 2024
    Configuration menu
    Copy the full SHA
    e50ad14 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    196dab6 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2024

  1. Fix metadata prop merging (#69807)

    ### What
    
    Fixes metadata merging issue on 14.2. There's a bug with React  on 14.2 as it bit outdated: while generating rsc payload, if we use fragment to wrap the metadata and noindex component, it will miss all the data. It works well with separating them as an array.
    It also requires #64058 to be applied as well so the output not-found page will having correct status 404, and then we can generate noindex metatag based on correct status
    
    Fixes #69778
    huozhi authored Sep 9, 2024
    Configuration menu
    Copy the full SHA
    747d365 View commit details
    Browse the repository at this point in the history
  2. unpin CNA tests from 14.2.3

    this reverts the change from 564b620
    lubieowoce committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    9a72ad6 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3756801 View commit details
    Browse the repository at this point in the history
  4. create-next-app: fix font file corruption when using import alias (#6…

    …9806)
    
    There's code that uses `glob` to find all template files and replaces
    the default import alias with whatever is specified during CNA. This
    does so without excluding fonts, and so we're unintentionally corrupting
    these `woff` files.
    
    This wasn't a problem in previous versions because we didn't use
    `localFont` in the default template, just `Inter`. The files were
    technically still being corrupted it just never manifested unless you
    went to actually use them.
    
    This is a quick fix to introduce minimal changes but ideally in a
    follow-up we should figure out a better solution for replacing aliases,
    ie by using an allowlist rather than an exclude list.
    
    h/t to @lubieowoce for the thorough test cases
    
    Fixes #69748
    
    ---------
    
    Co-authored-by: Janka Uryga <[email protected]>
    ztanner and lubieowoce committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    4bd3849 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7998745 View commit details
    Browse the repository at this point in the history
  6. v14.2.9

    vercel-release-bot committed Sep 9, 2024
    Configuration menu
    Copy the full SHA
    6fa8982 View commit details
    Browse the repository at this point in the history
Loading