Skip to content

Commit 53bb3e5

Browse files
committed
Create PR template, remove Webapp Related Directions
Remove checklist items that don't apply to a Python client
1 parent bc1d9c2 commit 53bb3e5

File tree

2 files changed

+18
-2
lines changed

2 files changed

+18
-2
lines changed

.github/PULL_REQUEST_TEMPLATE.md

Lines changed: 16 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
1+
## What does this PR do? How does it affect users?
2+
3+
## How should this be tested?
4+
5+
Step through the code line by line. Things to keep in mind as you review:
6+
- Are there any edge cases not covered by this code?
7+
- Does this code follow conventions (naming, formatting, modularization, etc) where applicable?
8+
9+
Fetch the branch and/or deploy to staging to test the following:
10+
11+
- [ ] Does the code compile without warnings (check shell, console)?
12+
- [ ] Do all tests pass?
13+
- [ ] If the feature sends data to Keen, is the data visible in the project if you run an extraction (include link to collection/query)?
14+
- [ ] If the feature saves data to a database, can you confirm the data is indeed created in the database?
15+
16+
## Related tickets?

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -54,14 +54,14 @@ Fetch the branch and/or deploy to staging to test the following:
5454
5555
- [ ] Does the code compile without warnings (check shell, console)?
5656
- [ ] Do all tests pass?
57-
- [ ] Does the UI, pixel by pixel, look exactly as expected (check various screen sizes, including mobile)?
58-
- [ ] If the feature makes requests from the browser, inspect them in the Web Inspector. Do they look as expected (parameters, headers, etc)?
5957
- [ ] If the feature sends data to Keen, is the data visible in the project if you run an extraction (include link to collection/query)?
6058
- [ ] If the feature saves data to a database, can you confirm the data is indeed created in the database?
6159
6260
## Related tickets?
6361
```
6462

63+
This PR template can be viewed rendered in Markdown [here](./.github/PULL_REQUEST_TEMPLATE.md). Github will auto-populate any new PRs filed with this template, so don't worry about copy-pasting it.
64+
6565
## How to report a bug
6666
If you find a security vulnerability, do NOT open an issue. Email [email protected] instead.
6767

0 commit comments

Comments
 (0)