remove 1 ThreadLocal by putting BSONDecoder in DBPort JAVA-130

From hans

Author: erh

src/main/com/mongodb/DBPort.java

@@ -23,6 +23,7 @@
 import java.util.*;
 import java.util.logging.*;
 
+import org.bson.*;
 import com.mongodb.util.*;
 
 public class DBPort {
@@ -93,7 +94,7 @@ private synchronized Response go( OutMessage msg , DBCollection coll )
                 return null;
 
             _processingResponse = true;
-            return new Response( coll , _in );
+            return new Response( coll , _in , _decoder);
         }
         catch ( IOException ioe ){
             close();
@@ -246,6 +247,7 @@ void checkAuth( DB db ){
     final DBPortPool _pool;
     final MongoOptions _options;
     final Logger _logger;
+    final BSONDecoder _decoder = new BSONDecoder();
 
     private Socket _socket;
     private InputStream _in;

src/main/com/mongodb/Response.java

@@ -26,7 +26,7 @@
 
 class Response {
 
-    Response( DBCollection collection ,  InputStream in )
+    Response( DBCollection collection ,  InputStream in, BSONDecoder decoder)
         throws IOException {
         _collection = collection;
 
@@ -53,8 +53,7 @@ class Response {
         else
             _objects = new ArrayList<DBObject>( _num );
 
-        DBCallback c = DBCallback.FACTORY.create( _collection );
-        BSONDecoder decoder = TL.get();
+        DBCallback c = DBCallback.FACTORY.create( _collection );        
 
         for ( int i=0; i<_num; i++ ){
             if ( user._toGo < 5 )
@@ -182,9 +181,4 @@ public String toString(){
 
     final List<DBObject> _objects;
 
-    static ThreadLocal<BSONDecoder> TL = new ThreadLocal<BSONDecoder>(){
-        protected BSONDecoder initialValue(){
-            return new BSONDecoder();
-        }
-    };
 }