enhancement: presigned-url validity getter

Author: hardikSinghBehl

aws/spring-cloud-aws-s3/src/main/java/io/reflectoring/configuration/AwsS3BucketProperties.java

@@ -1,5 +1,7 @@
 package io.reflectoring.configuration;
 
+import java.time.Duration;
+
 import org.springframework.boot.context.properties.ConfigurationProperties;
 import org.springframework.validation.annotation.Validated;
 
@@ -58,4 +60,9 @@ public class PresignedUrl {
 
 	}
 
+	public Duration getPresignedUrlValidity() {
+		var urlValidity = this.presignedUrl.validity;
+		return Duration.ofSeconds(urlValidity);
+	}
+
 }

aws/spring-cloud-aws-s3/src/main/java/io/reflectoring/service/StorageService.java

@@ -1,7 +1,6 @@
 package io.reflectoring.service;
 
 import java.net.URL;
-import java.time.Duration;
 
 import org.springframework.boot.context.properties.EnableConfigurationProperties;
 import org.springframework.stereotype.Service;
@@ -18,42 +17,40 @@
 @RequiredArgsConstructor
 @EnableConfigurationProperties(AwsS3BucketProperties.class)
 public class StorageService {
-	
+
 	private final S3Template s3Template;
 	private final AwsS3BucketProperties awsS3BucketProperties;
-		
+
 	@SneakyThrows
 	public void save(@NonNull final MultipartFile file) {
 		final var key = file.getOriginalFilename();
 		final var bucketName = awsS3BucketProperties.getBucketName();
 
 		s3Template.upload(bucketName, key, file.getInputStream());
 	}
-	
+
 	public S3Resource retrieve(@NonNull final String objectKey) {
 		final var bucketName = awsS3BucketProperties.getBucketName();
 		return s3Template.download(bucketName, objectKey);
 	}
-	
+
 	public void delete(@NonNull final String objectKey) {
 		final var bucketName = awsS3BucketProperties.getBucketName();
 		s3Template.deleteObject(bucketName, objectKey);
 	}
-	
+
 	public URL generateViewablePresignedUrl(@NonNull final String objectKey) {
 		final var bucketName = awsS3BucketProperties.getBucketName();
-		final var urlValidity = awsS3BucketProperties.getPresignedUrl().getValidity();
-		final var urlValidityDuration = Duration.ofSeconds(urlValidity);
-		
-		return s3Template.createSignedGetURL(bucketName, objectKey, urlValidityDuration);
+		final var urlValidity = awsS3BucketProperties.getPresignedUrlValidity();
+
+		return s3Template.createSignedGetURL(bucketName, objectKey, urlValidity);
 	}
-	
+
 	public URL generateUploadablePresignedUrl(@NonNull final String objectKey) {
 		final var bucketName = awsS3BucketProperties.getBucketName();
-		final var urlValidity = awsS3BucketProperties.getPresignedUrl().getValidity();
-		final var urlValidityDuration = Duration.ofSeconds(urlValidity);
+		final var urlValidity = awsS3BucketProperties.getPresignedUrlValidity();
 
-		return s3Template.createSignedPutURL(bucketName, objectKey, urlValidityDuration);
+		return s3Template.createSignedPutURL(bucketName, objectKey, urlValidity);
 	}
-	
+
 }