feat(create-vite): add qwik templates

[leifermendez]

pr-vite-qwik-convert.mp4

Description

A new template has been added for Qwik Framework

What is the purpose of this pull request?

• Bug fix
• [x ] New Feature
• Documentation update
• Other

Before submitting the PR, please make sure you do the following

• [x ] Read the Contributing Guidelines.
• [x ] Read the Pull Request Guidelines and follow the PR Title Convention.
• [x ] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
• [ x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
• Ideally, include relevant tests that fail without this PR but pass with it.

[bolt-new-by-stackblitz]

Run & review this pull request in StackBlitz Codeflow.

[manucorporat]

From what i see: the .gitignore needs to be called: _gitignore

[bluwy]

I don't think a QwikCity template fits here? Similarly we don't add the SvelteKit template here. At most it's a vanilla Vite + Qwik template similar to the other existing frameworks setup and design. And then we can add a CLI redirect to QwikCity.

[leifermendez]

I don't think a QwikCity template fits here? Similarly we don't add the SvelteKit template here. At most it's a vanilla Vite + Qwik template similar to the other existing frameworks setup and design. And then we can add a CLI redirect to QwikCity.

I get it! I changed the starter app and also I added the option to QwikCity like SvelteKit.

@manucorporat WDYT?

[ArnaudBarre]

There is multiple things that are off compared to others templates (not an issue but need to be justified):

• lib mode
• ssr entry
• tsconfig/.gitignore diverge from other templates

[manucorporat]

@patak-dev @ArnaudBarre core qwik team here! worked last week to make sure qwik's CSR is in pair with the rest, 100% standard vite starter, index.html as starting point!

[manucorporat]

@leifermendez think we should remove the .eslintrc.cjs

[patak-cat]

Thanks @manucorporat, I think we should also remove .eslintignore and .prettierignore. And to align with the rest of the starters, there should be a JS version too.

Also, you could add information on the template README.md or directly in the vite config file about the csr option you used.

We were discussing with @bluwy that with the previous setup that included low-level SSR handling, it was better to merge this into create-vite-extra. But with csr, at least to me, create-vite is a better place.

Just to set the expectations, create-vite templates are barebone and mainly intended to try out Vite (or do bug repros). We always point users to prefer the create starters from the frameworks when possible.

[manucorporat]

Done! @patak-dev removed the files as suggested and added the .js version

[manucorporat]

Added READMEs!

[patak-cat]

Are the .eslintrc.cjs a must? We only added eslint to the React templates because they said React was broken without the eslint hook rules. I think it would be better to remove eslint support if possible.

[patak-cat]

There is an extra [package-lock.json](https://github.com/vitejs/vite/pull/13620/files#diff-dded9ed3ccf0f6711806b389d69fe9ccff27addb409d7f9dd28a071a127cc65d) in the new JS template that should be removed too.

[manucorporat]

Not really, i misunderstood u, thought u wanted the eslint added! removed

[patak-cat]

The Vite logo has the same size as the framework logo in other templates. See

Same for the JS template

[patak-cat]

The templates prompts the user "Edit src/app.tsx and save to test HMR", but when trying it out there is a hard reload instead, and the state is lost. Tested the react one that has the same prompt and it is working. If this is a limitation with Qwik, maybe the prompt could be about editing another component. We have in Vue a HelloWorld component for example (because of unrelated reasons)

[manucorporat]

HMR is not implemented in Qwik CSR yet, CSR never been a focus.

Fixed the image size and remove that prompt to the user

[patak-cat]

Looks good to me now! Thanks for the changes.

[bluwy]

The changes look great and follows the convention! I have a small question but not 100% blocking this:

HMR is not implemented in Qwik CSR yet, CSR never been a focus.

I wonder if this CSR setup is something you'd recommend building with Qwik today? If not, it feels a bit weird keeping a template for it. In most docs it looks like QwikCity (or an SSR setup in general) is the preferred starting point.

[manucorporat]

There are uses cases! Qwik is equivalent to Vue, Solid, React, (same group). It dont need server, we are coming up with new uses cases for CSR, like mobile apps (Capacitor), Qwik automatic lazy loading is still interesting even without SSR involved!
However never been the active focus.

Regarding HMR i plan to work on this soon, for CSR and improvements for SSR too

[bluwy]

Awesome. If there are plans for improving CSR, let's get this in 👍