feat(create-vite): use @clack/prompts#19445
Conversation
|
Looks like it's failing on windows CI as there's an error happening for non-tty terminals. There's an upstream issue for this: bombshell-dev/clack#192 I guess it's kinda a blocker now that some windows user wouldn't be able to run Error messageParticularly it's erroring on this line |
|
Nice ✨ I pushed a patch that fixes the error on Windows (it reproduced on my machine). I'll make a PR upstream later on. I'm not sure if this fixes the Git bash case as that one didn't reproduce on my machine. It worked with powershell / cmd / git bash for me. |
|
I think this looks great! Awesome that all the options are visible again. |
|
Thanks for fixing it on windows! I wouldn't be able to figure it out myself. |
How EXACTLY did this PR fix the So now there is no way to trigger 'ignore' from the command line. |
Co-authored-by: sapphi-red <49056869+sapphi-red@users.noreply.github.com>
Description
Here's a video of me testing out the CLI:
clack-record.mp4
NOTE: I cmd+c during executing the react-router cli as it was taking a bit long. But it was working when testing manually.
I also fixed the
--overwriteflag support as the overwrite option is now a 3-option select rather than a boolean. (feature added in #15808). I also replacedminimistwithmri.dist/index.mjssize:Other improvements:
Since
@clack/promptsis more imperative, we could also add additional step messages likeusing xxx template(if--templateis passed), orfiles in xxx removed(if--overwriteis passed), etc. But I've kept the prompts as close to as before for now.