fix(create-app): lit-element templates package.json#3435
Merged
patak-cat merged 1 commit intovitejs:mainfrom May 16, 2021
patak-cat:fix/lit-element-templates
Merged
fix(create-app): lit-element templates package.json#3435patak-cat merged 1 commit intovitejs:mainfrom patak-cat:fix/lit-element-templates
patak-cat merged 1 commit intovitejs:mainfrom
patak-cat:fix/lit-element-templates
Conversation
underfin
approved these changes
May 15, 2021
Shinigami92
approved these changes
May 16, 2021
fi3ework
pushed a commit
to fi3ework/vite
that referenced
this pull request
May 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modify names in package.json of lit templates so they are unique and Jest stop issuing a warning.
Correct main and exports fields that were pointing to the wrong file, check vite.config.js of templates.
I don't know why we are generating a lib and not an app for lit templates. I imagine that the Lit team will switch these templates to an app when they update them to Lit 2.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).