Skip to content

chore: format#4233

Merged
antfu merged 1 commit intomainfrom
format
Jul 13, 2021
Merged

chore: format#4233
antfu merged 1 commit intomainfrom
format

Conversation

@Shinigami92
Copy link
Copy Markdown
Member

Description

Format AND add a '\n' to package.jsons

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@Shinigami92 Shinigami92 added the p1-chore Doesn't change code behavior (priority) label Jul 13, 2021
@Shinigami92 Shinigami92 requested review from antfu and patak-cat July 13, 2021 14:03
@Shinigami92 Shinigami92 self-assigned this Jul 13, 2021
`^` + require('../plugin-vue/package.json').version
}
fs.writeFileSync(pkgPath, JSON.stringify(pkg, null, 2))
fs.writeFileSync(pkgPath, JSON.stringify(pkg, null, 2) + '\n')
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I finally added this '\n' that without it gives me nightmares

@antfu antfu merged commit e519548 into main Jul 13, 2021
@antfu antfu deleted the format branch July 13, 2021 15:02
aleclarson pushed a commit to aleclarson/vite that referenced this pull request Nov 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p1-chore Doesn't change code behavior (priority)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants