fix: template-react-ts warning when importing path in vite.config.ts#8924
Merged
patak-cat merged 2 commits intovitejs:mainfrom Jul 5, 2022
Merged
fix: template-react-ts warning when importing path in vite.config.ts#8924patak-cat merged 2 commits intovitejs:mainfrom
patak-cat merged 2 commits intovitejs:mainfrom
Conversation
✅ Deploy Preview for vite-docs-main canceled.
|
bluwy
approved these changes
Jul 5, 2022
Member
bluwy
left a comment
bluwy
left a comment
There was a problem hiding this comment.
Should be a harmless addition as it's for the vite config only.
Contributor
Author
tests have runed, please see again~~, thanks |
Member
|
You can ignore the failing tests as it's flaky 🙂 The change in this PR isn't covered by CI so it should be safe. |
Contributor
Author
OK，thank you~ 😄 |
bluwy
approved these changes
Jul 5, 2022
patak-cat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fix: template-react-ts is warning when I import path in vite.config.ts
Additional context
What is the purpose of this pull request?