Skip to content

Commit ad987ed

Browse files
authored
Merge pull request #8451 from kaovilai/new-changelog-brackets
Makefile: new-changelog handles `()` in pr title.
2 parents af85b7d + 3517487 commit ad987ed

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

Makefile

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -383,12 +383,12 @@ go-generate:
383383
# make new-changelog CHANGELOG_BODY="Changes you have made"
384384
new-changelog: GH_LOGIN ?= $(shell gh pr view --json author --jq .author.login 2> /dev/null)
385385
new-changelog: GH_PR_NUMBER ?= $(shell gh pr view --json number --jq .number 2> /dev/null)
386-
new-changelog: CHANGELOG_BODY ?= "$(shell gh pr view --json title --jq .title)"
386+
new-changelog: CHANGELOG_BODY ?= '$(shell gh pr view --json title --jq .title)'
387387
new-changelog:
388388
@if [ "$(GH_LOGIN)" = "" ]; then \
389389
echo "branch does not have PR or cli not logged in, try 'gh auth login' or 'gh pr create'"; \
390390
exit 1; \
391391
fi
392392
@mkdir -p ./changelogs/unreleased/ && \
393393
echo $(CHANGELOG_BODY) > ./changelogs/unreleased/$(GH_PR_NUMBER)-$(GH_LOGIN) && \
394-
echo "\"$(CHANGELOG_BODY)\" added to ./changelogs/unreleased/$(GH_PR_NUMBER)-$(GH_LOGIN)"
394+
echo \"$(CHANGELOG_BODY)\" added to "./changelogs/unreleased/$(GH_PR_NUMBER)-$(GH_LOGIN)"

0 commit comments

Comments
 (0)